[Bug 16741] New: Dead code (?) - sub itemissues in C4/Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Bug ID: 16741 Summary: Dead code (?) - sub itemissues in C4/Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org It seems that sub itemissues, defined in C4/Circulation.pm, is never used. Behalve of C4/Circulation.pm it is only found (but not used) in: catalogue/moredetail.pl:use C4::Circulation; # to use itemissues To verify: - git grep itemissues - comment out line 33 in catalogue/moredetail.pl, verifiy that there are no errors or side effects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Dead code (?) - sub |Remove dead code "sub |itemissues in |itemissues" from |C4/Circulation.pm |C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 54259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54259&action=edit Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54259|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 54284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54284&action=edit Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54284|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54289&action=edit Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16741 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org