https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20978 |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update |Remove |C4::Accounts::manualinvoice |C4::Accounts::manualinvoice |to use |(use |Koha::Account->add_debit |Koha::Account->add_debit | |instead) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83257&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83259&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83261&action=edit Bug 21747: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83263&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83260|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83265&action=edit Bug 21747: Update members/manivoice to use add_debit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83262|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83267&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83264|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83269&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83271&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test Plan 1) Apply patches and run the test suit to check for regressions in tests 2) Use the manual invoice page to add a new invoice, this should work 3) As above, but use a non-existent item number and check that you get a suitable warning still. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Need rebase due to bug 21915. Also qa tools have some complains: FAIL Koha/Patron.pm FAIL pod *** ERROR: Spurious text after =cut in file Koha/Patron.pm FAIL members/maninvoice.pl FAIL valid (Missing operator before $error?) Global symbol "$template" requires explicit package name (did you forget to declare "my $template"?) Scalar found where operator expected Can't redeclare "my" in "my" members/maninvoice.pl has too many errors. Global symbol "$cookie" requires explicit package name (did you forget to declare "my $cookie"?) Global symbol "$loggedinuser" requires explicit package name (did you forget to declare "my $loggedinuser"?) Global symbol "$error" requires explicit package name (did you forget to declare "my $error"?) "my" variable $input masks earlier declaration in same scope Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference constructor) syntax error -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83267|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84729&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83269|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84731&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83271|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84733&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- I am still getting this fron QA tools: FAIL members/maninvoice.pl FAIL valid (Missing operator before $error?) Global symbol "$template" requires explicit package name (did you forget to declare "my $template"?) Scalar found where operator expected Can't redeclare "my" in "my" members/maninvoice.pl has too many errors. Global symbol "$cookie" requires explicit package name (did you forget to declare "my $cookie"?) Global symbol "$loggedinuser" requires explicit package name (did you forget to declare "my $loggedinuser"?) Global symbol "$error" requires explicit package name (did you forget to declare "my $error"?) "my" variable $input masks earlier declaration in same scope Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference constructor) syntax error Also test don't pass: t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. 1/6 # Failed test 'Got correct offset type' # at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 81. # got: 'Lost Item' # expected: 'Manual Debit' # Failed test 'No tests run for subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew"' # at t/db_dependent/Circulation.t line 703. Can't use string ("FU") as a subroutine ref while "strict refs" in use at t/db_dependent/Circulation.t line 668. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84730|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85321&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84732|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85323&action=edit Bug 21756: Update members/manivoice to use add_debit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85325&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85327&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- \o/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Josef Moravec from comment #36)

I am sorry, but the tests are still not passing:

t/db_dependent/Koha/Patrons.t .. 10/33 DBD::mysql::st execute failed: Field 'type' doesn't have a default value [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`) VALUES ( ?, ? )" with ParamValues: 0=5.000000, 1='68'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run!

# Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"' # at t/db_dependent/Koha/Patrons.t line 473.

t/db_dependent/Koha/Holds.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=42, 1='69', 2='Hold Expired'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # Looks like you planned 4 tests but ran 3.

# Failed test 'charge_cancel_fee parameter' # at t/db_dependent/Koha/Holds.t line 134.

I think that some new values should be added to account_offset_types...

The tests pass for me - I wonder what the difference could be? Just applied, reset_all and ran them. The only issue I see is lots of warnings in Circulation.t, but I tihnk there was another bug for those. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Having looked again this morning, I'm OK with the accounttype being altered in the test there.. it mimics the behaviour of the FU -> F transition that happens in C4::Overdues. So.. I'm re-running the full test suit one last time in a totally fresh koha-testing-docker to see if I can replicate your failures.. I'll report back once the test run has completed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85320|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85420&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85322|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85422&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85324|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85424&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85326|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85426&action=edit Bug 21756: (QA follow-up) Fixes for rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85350|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85428&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85430&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove |Deprecate |C4::Accounts::manualinvoice |C4::Accounts::manualinvoice |(use |(use |Koha::Account->add_debit |Koha::Account->add_debit |instead) |instead) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85421|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85506&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85424|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85508&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85427|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85510&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85429|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85512&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85514&action=edit Bug 21756: (QA follow-up) Add `Account Management Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85505|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85638&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85507|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85640&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85509|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85642&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85511|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85644&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85513|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85646&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85515|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85648&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dopey mistake corrected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #78 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85655&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #80 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85657&action=edit Bug 21756: Add deprecation warning to manualinvoice https://bugs.koha-community.org/show_bug.cgi?id=21756 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #82 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85659&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #84 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85661&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #86 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85663&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #88 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85665&action=edit Bug 21756: (QA follow-up) Add missing offset_types to installer file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22393 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85655|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86266&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85657|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86268&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85659|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86270&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85661|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86272&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85663|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86274&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86276&action=edit Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Freshly rebased -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooh, I thought Tomas was doing a final QA as both Josef and I worked on it and in effect signed off each others work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- Setting to SO for final QA pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86265|0 |1 is obsolete| | Attachment #86266|0 |1 is obsolete| | Attachment #86267|0 |1 is obsolete| | Attachment #86268|0 |1 is obsolete| | Attachment #86269|0 |1 is obsolete| | Attachment #86270|0 |1 is obsolete| | Attachment #86271|0 |1 is obsolete| | Attachment #86272|0 |1 is obsolete| | Attachment #86273|0 |1 is obsolete| | Attachment #86274|0 |1 is obsolete| | Attachment #86275|0 |1 is obsolete| | Attachment #86276|0 |1 is obsolete| | --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86441&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86443&action=edit Bug 21756: Replace manualinvoice with add_debit in tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86445&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86447&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86449&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86451&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Bug 21756 depends on bug 21721, which changed state. Bug 21721 Summary: Update C4::Circulation::AddRenewal to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.