[Bug 21939] New: Permissions for Holds History Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Bug ID: 21939 Summary: Permissions for Holds History Tab Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jzairo@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com With bug 14919 we added the availability to allow staff to view the Holds History tab for a patron if intranetreadinghistory is set to allow. However, depending on the permissions, a staff member has they may or may not be able to see. In order to view the Holds History Tab a staff member must have the full borrowers permission. borrowers Add, modify and view patron information edit_borrowers Add, modify and view patron information view_borrower_infos_from_any_libraries View patron info from any libraries. If not set the logged in user could only access patron info from its own library or group of libraries. If they only have edit_borrowers Add, modify and view patron information, they will not have access to view the Holds History tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #1 from AspenCat Team <aspencatteam@clicweb.org> --- Been getting a lot of feedback from our libraries that they would like to see this permission problem fixed so they can view holds history without the problems that are created by allowing all of our libraries to view and edit patrons from other libraries. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94972&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permissions for Holds |Permission for holds |History Tab |history tab is too strict -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tried fixing it as suggested, can you please test? Should work fine on sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94972|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 94991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94991&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94991|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 95128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95128&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95128|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95147&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Hi, May we have this for 19.05 as well? It applies cleanly and works nicely there. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley@catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00, 18.11.12 |19.11.00, 19.05.06, released in| |18.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org