[Bug 42014] New: Patron lists tab shows blank content when no patron lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Bug ID: 42014 Summary: Patron lists tab shows blank content when no patron lists exist Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org On the patron detail page, the "Patron lists" tab renders completely empty when no patron lists exist in the system. The tab is shown (because the borrowernumber 51 (koha) for example has manage_patron_lists permission), but the dynamically loaded content from patron-lists-tab.tt contains no HTML, both [% IF in_lists %] and [% IF available_lists && CAN_user_tools_manage_patron_lists %] evaluate to false. Other tabs follow the convention of showing an empty state message (e.g. "Patron has nothing on hold." for holds, "Patron has nothing booked." for bookings). The patron lists tab should do the same, with a message like "No patron lists. Create a new list." linking to /cgi-bin/koha/patron_lists/add-modify.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194739&action=edit Bug 42014: Show empty state message on patron lists tab - When no patron lists exist in the system, the patron lists tab on the patron detail page renders completely blank - Other tabs follow the convention of showing a message in the empty state (e.g. "Patron has nothing on hold.") - Add an empty state message with a link to create a new patron list, matching the established pattern To test: - Go to a patron detail page and click the "Patron lists" tab - If no patron lists exist, observe the tab is blank - Apply patch - Repeat the above steps - Verify the tab now shows "Patron is not on any list." with a link to create a new patron list - Click the link and create a patron list - Return to the patron detail page and verify the "Add patron to list" dropdown now appears instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- In a case where the logged in user has permission to manage lists, "Patron is not on any list" displays even if the patron is on a list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks, will check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194771&action=edit Bug 42014: (follow-up) Only show empty state when patron is not on any list - The empty state message was shown when available_lists was empty but the patron was already on all existing lists - Add !in_lists guard so the message only displays when the patron is truly not on any list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194739|0 |1 is obsolete| | Attachment #194771|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194781&action=edit Bug 42014: Show empty state message on patron lists tab - When no patron lists exist in the system, the patron lists tab on the patron detail page renders completely blank - Other tabs follow the convention of showing a message in the empty state (e.g. "Patron has nothing on hold.") - Add an empty state message with a link to create a new patron list, matching the established pattern To test: - Go to a patron detail page and click the "Patron lists" tab - If no patron lists exist, observe the tab is blank - Apply patch - Repeat the above steps - Verify the tab now shows "Patron is not on any list." with a link to create a new patron list - Click the link and create a patron list - Return to the patron detail page and verify the "Add patron to list" dropdown now appears instead Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194782&action=edit Bug 42014: (follow-up) Only show empty state when patron is not on any list - The empty state message was shown when available_lists was empty but the patron was already on all existing lists - Add !in_lists guard so the message only displays when the patron is truly not on any list Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194996&action=edit Bug 42014: Show empty state message on patron lists tab - When no patron lists exist in the system, the patron lists tab on the patron detail page renders completely blank - Other tabs follow the convention of showing a message in the empty state (e.g. "Patron has nothing on hold.") - Add an empty state message with a link to create a new patron list, matching the established pattern To test: - Go to a patron detail page and click the "Patron lists" tab - If no patron lists exist, observe the tab is blank - Apply patch - Repeat the above steps - Verify the tab now shows "Patron is not on any list." with a link to create a new patron list - Click the link and create a patron list - Return to the patron detail page and verify the "Add patron to list" dropdown now appears instead Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194997&action=edit Bug 42014: (follow-up) Only show empty state when patron is not on any list - The empty state message was shown when available_lists was empty but the patron was already on all existing lists - Add !in_lists guard so the message only displays when the patron is truly not on any list Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42014 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.05.00,25.11.04,25.05.11 |26.05.00,25.11.04,25.05.11, released in| |24.11.16 --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.16 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org