[Bug 26061] New: Improve style of sidebar datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Bug ID: 26061 Summary: Improve style of sidebar datepickers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 24363 Browser support of the CSS calc() function is broad enough that we can use it to prevent the datepicker icon from wrapping below the form field. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 [Bug 24363] Datepicker calendar is not always sexy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107359&action=edit Bug 26061: Improve style of sidebar datepickers This patch makes a small change to the staff interface CSS so that datepicker form fields in sidebar forms don't force the datepicker icon onto a second line. The change uses the CSS calc() function to specify that form fields with a .hasDatepicker class (dynamically added by jqueryUI) have a width of 100% minus 20 pixels, leaving room for the datepicker icon. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - View a page in the staff interface which has a datepicker field in a sidebar form and confirm that the icon stays on the same line as the firm field at varying browser widths. Examples: - Reports -> Saved SQL reports - Circulation -> Overdues - Acquisitions -> Late orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107359|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 107426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107426&action=edit Bug 26061: Improve style of sidebar datepickers This patch makes a small change to the staff interface CSS so that datepicker form fields in sidebar forms don't force the datepicker icon onto a second line. The change uses the CSS calc() function to specify that form fields with a .hasDatepicker class (dynamically added by jqueryUI) have a width of 100% minus 20 pixels, leaving room for the datepicker icon. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - View a page in the staff interface which has a datepicker field in a sidebar form and confirm that the icon stays on the same line as the firm field at varying browser widths. Examples: - Reports -> Saved SQL reports - Circulation -> Overdues - Acquisitions -> Late orders Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107426|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107541&action=edit Bug 26061: Improve style of sidebar datepickers This patch makes a small change to the staff interface CSS so that datepicker form fields in sidebar forms don't force the datepicker icon onto a second line. The change uses the CSS calc() function to specify that form fields with a .hasDatepicker class (dynamically added by jqueryUI) have a width of 100% minus 20 pixels, leaving room for the datepicker icon. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - View a page in the staff interface which has a datepicker field in a sidebar form and confirm that the icon stays on the same line as the firm field at varying browser widths. Examples: - Reports -> Saved SQL reports - Circulation -> Overdues - Acquisitions -> Late orders Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a good improvement, but I wonder if those date fields wouldn't look a little nicer if they were even a little shorter - at the moment they are very wide compared to date fields in other places (patron record for example). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #4)
I think this is a good improvement, but I wonder if those date fields wouldn't look a little nicer if they were even a little shorter
The date fields in the sidebar are different than elsewhere because all form fields in the sidebar are styled to be the same width. I think this consistency looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org