[Bug 20910] New: 773$g not displayed if $0 is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Bug ID: 20910 Summary: 773$g not displayed if $0 is present Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org If the $0 subfield is present (EasyAnalytics) the $g subfield is not displayed as in other display modes. This is probably a minor mistake in the XSLT logic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11849, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5528 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75960&action=edit Bug 20910: Display 773$g when $0 is present too This patch makes the XSLT logic add the $g subfield in the 773 display in both the OPAC and staff interface MARC21 record detail pages. The XSLT chooses between different ways to create the link for the related content, but then it only adds the $g in two of the cases. There's no obvious reason for a different display. To test: - Have a record with: =773 $tHost title $gp4. => SUCCESS: Notice the Detail view shows: In: Host title p4. - Have another record with: =773 $tHost title $gp4. $w100 - Enable UseControlNumber (only to cover the case): => SUCCESS: Notice the detail view shows In: Host title p4. - Have another record with: =773 $tHost title $gp4. $0456 => FAIL: The Detail view doesn't show p4. - Apply this patch - Reload => SUCCESS: The Detail view displays p4.! - Sign off :-D Sponsored-by: Escuela de Orientacion Lacaniana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75961&action=edit Bug 20910: Tidy 773 handling XSLT code There's happiness too. You know. Sponsored-by: Escuela de Orientacion Lacaniana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75960|0 |1 is obsolete| | --- Comment #3 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 78741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78741&action=edit Bug 20910: Display 773$g when $0 is present too This patch makes the XSLT logic add the $g subfield in the 773 display in both the OPAC and staff interface MARC21 record detail pages. The XSLT chooses between different ways to create the link for the related content, but then it only adds the $g in two of the cases. There's no obvious reason for a different display. To test: - Have a record with: =773 $tHost title $gp4. => SUCCESS: Notice the Detail view shows: In: Host title p4. - Have another record with: =773 $tHost title $gp4. $w100 - Enable UseControlNumber (only to cover the case): => SUCCESS: Notice the detail view shows In: Host title p4. - Have another record with: =773 $tHost title $gp4. $0456 => FAIL: The Detail view doesn't show p4. - Apply this patch - Reload => SUCCESS: The Detail view displays p4.! - Sign off :-D Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75961|0 |1 is obsolete| | --- Comment #4 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 78742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78742&action=edit Bug 20910: Tidy 773 handling XSLT code There's happiness too. You know. Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78741|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 80123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80123&action=edit Bug 20910: Display 773$g when $0 is present too This patch makes the XSLT logic add the $g subfield in the 773 display in both the OPAC and staff interface MARC21 record detail pages. The XSLT chooses between different ways to create the link for the related content, but then it only adds the $g in two of the cases. There's no obvious reason for a different display. To test: - Have a record with: =773 $tHost title $gp4. => SUCCESS: Notice the Detail view shows: In: Host title p4. - Have another record with: =773 $tHost title $gp4. $w100 - Enable UseControlNumber (only to cover the case): => SUCCESS: Notice the detail view shows In: Host title p4. - Have another record with: =773 $tHost title $gp4. $0456 => FAIL: The Detail view doesn't show p4. - Apply this patch - Reload => SUCCESS: The Detail view displays p4.! - Sign off :-D Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78742|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 80124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80124&action=edit Bug 20910: Tidy 773 handling XSLT code There's happiness too. You know. Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored-by: Escuela de release notes| |Orientacion Lacaniana CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |Jesse Maseto patch off| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x fro 18.05.05. I chose to only backport the first patch.. should aid in easy identification of the change vs the tidy for server admins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- 1st patch : Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored-by: Escuela de | release notes|Orientacion Lacaniana | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org