[Bug 35426] New: Improve layout of bookings modal form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Bug ID: 35426 Summary: Improve layout of bookings modal form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 29002 The bookings modal form, triggered on the staff interface page when you click the "Place bookings" button, has an awkward layout because the fieldset with "rows" class doesn't work well there. Changing the class to "brief" makes it work better. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159312&action=edit Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159312|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159454&action=edit Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159454|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159963&action=edit Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 [Bug 35532] Use of calendar for date range in bookings is not clear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35532 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 [Bug 35532] Use of calendar for date range in bookings is not clear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 [Bug 35532] Use of calendar for date range in bookings is not clear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not sure I agree this looks better... now it's pushed the modal looks more odd to me than it did before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162974&action=edit Old vs New -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can we do better here in general for modal based forms Owen? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- In fact.. all the modals I've created that include a form use 'rows' rather than 'brief' and personally I think they're clearer looking.. see all the modals available on the accounts pages? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED Version(s)|24.05.00,23.11.04 |24.05.00 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah reading comments I prefer not backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think we can backport this regardless of my negative comments.. I'd just love to see us get more consistent overall somehow in the future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Bug 35426 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org