[Bug 24111] New: Incorrect "Can't create any orders" alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Bug ID: 24111 Summary: Incorrect "Can't create any orders" alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6994 [Bug 6994] 'No budget defined' showing up although budgets and funds are defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95811&action=edit Bug 24111: Remove incorrect "Can't create any orders" alert It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner. Test plan: 0/ Add an owner to all of your funds 1/ Create an order from an existing record => Without this patch you should see the alert at the bottom of the result list => With this patch applied you should not see it QA will compare with the 2 other occurrences, in acqui/basket.pl and acqui/booksellers.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se --- Comment #2 from Stina Hallin <stina.hallin@ub.lu.se> --- Hello, I cannot recreate the error message in the sandbox. I can recreate it in our own test Koha on version 19.05.04. Of course there can be differences in our setups. I have tried the sandbox both with and without the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- `error: sha1 information is lacking or useless (acqui/neworderbiblio.pl).`.. any chance of a rebase on this one Jonathan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24347 Resolution|--- |WONTFIX --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- acqui/neworderbiblio.pl has been removed by bug 24347 and should have fixed the issue reported initially. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org