[Bug 16288] New: Edifact sysprefs EDIfactEAN and EDIInvoicesShippingBudget problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Bug ID: 16288 Summary: Edifact sysprefs EDIfactEAN and EDIInvoicesShippingBudget problems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 7736 introduced this two problematic sysprefs: EDIInvoicesShippingBudget: * sysprefs.sql: YAY! * updatedatabase.pl: YAY! * acquisitions.pref: BOOOOO, missing * The syspref is not actually used: To reproduce: - Run $ git grep EDIInvoicesShippingBudget => FAIL: Only shows in sysprefs.sql and updatedatabase.pl EDIfactEAN: * sysprefs.sql: BOOOOO, missing * updatedatabase.pl: BOOOOO, missing * acquisitions.pref: BOOOOO, missing * The syspref is actually used: To reproduce: - Run $ git grep EDIfactEAN => FAIL: The not-introduced syspref is actually used: Koha/EDI.pm: $ean ||= C4::Context->preference('EDIfactEAN'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736 Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 51462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51462&action=edit Proposed patch Remove the reference to the EAN syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 51463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51463&action=edit Proposed patch REmove the shipping budget syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51462|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51466&action=edit Bug 16288: Remove Reference to obsolete EAN syspref Remove reference to obsolete syspref EDIfactEAN which was present in earlier test version of EDI code but should not now be used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51463|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51467&action=edit Bug 16288: Remove unused EDI Shipping Budget syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51468&action=edit Bug 16288: (QA followup) Remove the syspref INSERT line Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51466|0 |1 is obsolete| | Attachment #51467|0 |1 is obsolete| | Attachment #51468|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51518&action=edit Bug 16288: Remove Reference to obsolete EAN syspref Remove reference to obsolete syspref EDIfactEAN which was present in earlier test version of EDI code but should not now be used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51519&action=edit Bug 16288: Remove unused EDI Shipping Budget syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51520&action=edit Bug 16288: (QA followup) Remove the syspref INSERT line Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51521&action=edit Bug 16288: Remove EDIInvoicesShippingBudget for devs Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Colin, Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org