[Bug 26725] New: Improve link text on Patron attributes administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Bug ID: 26725 Summary: Improve link text on Patron attributes administration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Blocks: 26722 There is a link labelled "here" that should be improved on the patron attributes page. To test: - Set ExtendedPatronAttributes system preference to "Don't enable" - Go to Administration > Patron attribute types The "here" link in the blue box at the top of the page should have a more meaningful link text. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 [Bug 26722] [Omnibus] Don't use "here" and similar as a link text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 112314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112314&action=edit bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- This all works as per the test plan, but I would: - just link the system preference name - put system preference in sentence case. A nice improvement and gets rid of the 'click here' type links! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 112315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112315&action=edit bug 26725: link text changed to just system preference name. "system preference" put in sentence case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Attached patch that fixes your notes in comment #2. Could you please test again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112314|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 112319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112319&action=edit bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112315|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 112320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112320&action=edit bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112319|0 |1 is obsolete| | Attachment #112320|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112343&action=edit Bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112344&action=edit Bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112345&action=edit Bug 26725: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |tal.rogoff@cass.govt.nz --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Now Tal has a Bugzilla account, I'll set her as the assignee :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Congratulations Tal for your first patch pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | Status|Pushed to master |RESOLVED --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Lucas has also backported this to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org