[Bug 22331] New: Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Bug ID: 22331 Summary: Lost items that are written off gives credit when returned Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeuber@cityoffargo.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- When a lost item is written off by the library, but later returned, Koha gives a credit for that item. To recreate: 1. Ensure "Refund lost item fee" is set to "Yes" in Circulation and Fine Rules. 2. Check out an item to a patron. 3. Mark item as lost. Replacement price should be added to their account. 4. Write off the fee. 5. Return the item. A refund is generated. A write off should not generate a refund in this situation. Is it possible this is related to Bug 19919 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- The issue appears to be from incorrectly assigned 'accountno' in Koha::Account->pay 88 # We should remove accountno, it is no longer needed 89 my $last = $self->lines->search( 90 {}, 91 { order_by => 'accountno' } )->next(); 92 my $accountno = $last ? $last->accountno + 1 : 1; The default order is ASC, so we end up assigning the lowest here Then in C4::Circulation->_FixAccountForLostAndReturned 2387 # check for charge made for lost book 2388 my $accountlines = Koha::Account::Lines->search( 2389 { 2390 itemnumber => $itemnumber, 2391 accounttype => { -in => [ 'L', 'Rep', 'W' ] }, 2392 }, 2393 { 2394 order_by => { -desc => [ 'date', 'accountno' ] } 2395 } 2396 ); We order the lines by accountno to get the most recent, however, the numbers are wrong so we don't get the most recent payment or write off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21683 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |WONTFIX --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- 18.05 is officially end of life at this point and I believe this bug is fixed in more recent versions... certainly, accountno was removed in 19.05, though not backported to 18.11 as far as I'm aware.. at this point, I would suggest we close this bug recommend an upgrade to 19.05 or above. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org