[Bug 14030] New: Add Georgian language and fix Kannada language code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bug ID: 14030 Summary: Add Georgian language and fix Kannada language code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Add Georgian language Georgian - ka - geo - ქართული Fix Kannada language ISO639-1 code
From 'ka' to 'kn'
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38224&action=edit Bug 14030: Add Georgian language and fix Kannada language code This patch adds Georgian language and a fix wrong language code Language added: Georgian - ka - geo I selected 'geo' for ISO639-2 instead of 'kat' because it's the same code form http://www.loc.gov/marc/languages/language_code.html Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn' To test: 1) Apply the patch 2) Run updatedatabase.pl (once) 3) Check language, e.g. go to staff > search > More options > Limits and search for Georgian on language list I only added language code 'ka', not script 'Geor' nor country 'GE', the plan is to name translation files 'ka-*', but can ammend the patch if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 38224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38224 Bug 14030: Add Georgian language and fix Kannada language code Review of attachment 38224: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14030&attachment=38224) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_14030-Add_Georgian_fix_Kannada_code.sql @@ +1,3 @@
+UPDATE language_subtag_registry SET subtag = 'kn' WHERE subtag = 'ka' AND description = 'Kannada'; + +UPDATE language_rfc4646_to_iso639 SET rfc4646_subtag = 'kn' WHERE rfc4646_subtag = 'ka' AND iso639_2_code = 'kan';
Good idea to include the iso639_2_code in the condition. Makes it runnable multiple times (not that one should). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- I'm wondering, are the id columns of the language tables even used? If so, where? If not, then why don't we have unique constraints that actually mean that we could write this SQL such that it could be run multiple times? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38296&action=edit Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38224|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38297&action=edit Bug 14030: Add Georgian language and fix Kannada language code This patch adds Georgian language and a fix wrong language code Language added: Georgian - ka - geo I selected 'geo' for ISO639-2 instead of 'kat' because it's the same code form http://www.loc.gov/marc/languages/language_code.html Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn' To test: 1) Apply the patch 2) Run updatedatabase.pl (once) 3) Check language, e.g. go to staff > search > More options > Limits and search for Georgian on language list I only added language code 'ka', not script 'Geor' nor country 'GE', the plan is to name translation files 'ka-*', but can ammend the patch if needed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38296|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38298&action=edit Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- I can't sign off my own patches, hence we still need sign off. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38298|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38344&action=edit [SIGNED-OFF] Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors, test run successfully, no more duplicates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38297|0 |1 is obsolete| | Attachment #38344|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38356&action=edit [PASSED QA] Bug 14030: Add Georgian language and fix Kannada language code This patch adds Georgian language and a fix wrong language code Language added: Georgian - ka - geo I selected 'geo' for ISO639-2 instead of 'kat' because it's the same code form http://www.loc.gov/marc/languages/language_code.html Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn' To test: 1) Apply the patch 2) Run updatedatabase.pl (once) 3) Check language, e.g. go to staff > search > More options > Limits and search for Georgian on language list I only added language code 'ka', not script 'Geor' nor country 'GE', the plan is to name translation files 'ka-*', but can ammend the patch if needed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38357&action=edit [PASSED QA] [PASSED QA] Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors, test run successfully, no more duplicates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed German description. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Well done Bernardo! First patchset to use the new atomicupdate schema! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14678 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org