https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine Payments Should Show What Was Paid For -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64297&action=edit Bug 18805 - Add ability to use up account credits Right now, in Koha, credits always have a static amount outstanding. So if a patron owes $10 in fines, and has a $10 credit, they technically owe nothing, but yet they still owe $10. This seems rather confusing. Instead, we should add the ability for credits to be used to pay down closed out fines and other fees. Test Plan: 1) Apply this patch and dependencies 2) Create a manual credit of some amount 3) Create a manual invoice 4) Note the manual invoice was automatically paid down using the balance from the manual credit! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #2 from Lisette <lisetteslatah@gmail.com> --- After applying the patch when we applied a manual credit we got the following error: SOFTWARE ERROR DBIx::Class:Storage::DBI::_dbh_execute():table 'koha_sandbox1.accountoffsets' doesn't exist doesn't exist at /var/lib/koha/sandbox/1.kohaclone/koha/object.pm line 121. The credit did apply. Same error when applying the manual credit. Behavior appears to be the same both before and after patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I think this is a change in behaviour that was inadvertantly added into - see bug 18580 for one case of it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- When trying to suspend a hold from the holds list in staff, there is an internal server error that translates to: Can't call method "ymd" on an undefined value at /home/vagrant/kohaclone/Koha/Hold.pm line 65. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64297|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72025&action=edit Bug 18805 - Add ability to use up account credits Right now, in Koha, credits always have a static amount outstanding. So if a patron owes $10 in fines, and has a $10 credit, they technically owe nothing, but yet they still owe $10. This seems rather confusing. Instead, we should add the ability for credits to be used to pay down closed out fines and other fees. Test Plan: 1) Apply this patch and dependencies 2) Create a manual credit of some amount 3) Create a manual invoice 4) Note the manual invoice was automatically paid down using the balance from the manual credit! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #8)

(In reply to Katrin Fischer from comment #6)

...

When trying to suspend a hold from the holds list in staff, there is an internal server error that translates to:

Can't call method "ymd" on an undefined value at /home/vagrant/kohaclone/Koha/Hold.pm line 65.

Can you test again? I can't recreate your error. My guess is it was an unrelated bug.

I wonder if this comment ended up on the wrong bug report? It appears really unrelated to the bug topic now and I don't remember. Please discount it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Bug 18805 depends on bug 2696, which changed state. Bug 2696 Summary: Fine payments should show what was paid for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81609&action=edit Bug 18805: Add ability to use up account credits Right now, in Koha, credits always have a static amount outstanding. So if a patron owes $10 in fines, and has a $10 credit, they technically owe nothing, but yet they still owe $10. This seems rather confusing. Instead, we should add the ability for credits to be used to pay down closed out fines and other fees. Test Plan: 1) Apply this patch and dependencies 2) Create a manual credit of some amount 3) Create a manual invoice 4) Note the manual invoice was automatically paid down using the balance from the manual credit! Followed test plan, patch worked as described. I also ran t/db_dependent/Accounts.t test which passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21896 Status|Signed Off |ASSIGNED Patch complexity|Medium patch |Small patch Assignee|kyle@bywatersolutions.com |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm taking this one with Kyle's permission. I rewrite and moved the Koha::Account::normalize_balance method to bug 21896. It is fully covered by tests there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 [Bug 21896] Add Koha::Account::normalize_balance -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82686&action=edit Bug 18805: Add ability to use up account credits This patch introduces a new button in the 'Pay fines' tab on the patron's account page. This button, labeled 'Normalize account' is only displayed when outstanding credits are available, that could be used to pay up existing debts. When clicking the button, the Koha::Account::normalize_balance method (bug 21896) is used for the purpose. To test: - Apply this patch (on top of 21896) - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than one) - Go to the 'Pay fines' tab => SUCCESS: No 'Normalize account' button is displayed. - On the 'create manual credit' tab, create a couple credits. - Go to the 'Pay fines' => SUCCESS: 'Normalize account' button is displayed - Click on 'Normalize account' => SUCCESS: Outstanding credits have been used to pay up debts. - Play with different options (credit excedes debts and vice-versa, they match, etc) => SUCCESS: They all work as expected - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Tomás Cohen Arazi from comment #10)

Right now, we are able to create credits (mancredit.pl) but there's no way to 'use' the existing credit against existing outstanding (debit) lines. This is odd in the interface and worth working on.

I don't think this should be implemented as an automatic feature in the first place. I would rather implement a way to assign remaining credits to specific lines, and THEN add the option to do it automatically, maybe syspref-controlled (better by payment type ;-))

I do hope an automatic setting is in the near future. One would assume credit would be used automatically. I don't know of many places that don't automatically use your credit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Christopher Brannon <cbrannon@cdalibrary.org> --- Sorry, needed a restart. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82686|0 |1 is obsolete| | --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82711&action=edit Bug 18805: Add ability to use up account credits This patch introduces a new button in the 'Pay fines' tab on the patron's account page. This button, labeled 'Normalize account' is only displayed when outstanding credits are available, that could be used to pay up existing debts. When clicking the button, the Koha::Account::normalize_balance method (bug 21896) is used for the purpose. To test: - Apply this patch (on top of 21896) - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than one) - Go to the 'Pay fines' tab => SUCCESS: No 'Apply credits' button is displayed. - On the 'create manual credit' tab, create a couple credits. - Go to the 'Pay fines' => SUCCESS: 'Apply credits' button is displayed - Click on 'Apply credits' => SUCCESS: Outstanding credits have been used to pay up debts. - Play with different options (credit excedes debts and vice-versa, they match, etc) => SUCCESS: They all work as expected - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82711|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82712&action=edit Bug 18805: Add ability to use up account credits This patch introduces a new button in the 'Pay fines' tab on the patron's account page. This button, labeled 'Normalize account' is only displayed when outstanding credits are available, that could be used to pay up existing debts. When clicking the button, the Koha::Account::normalize_balance method (bug 21896) is used for the purpose. To test: - Apply this patch (on top of 21896) - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than one) - Go to the 'Pay fines' tab => SUCCESS: No 'Apply credits' button is displayed. - On the 'create manual credit' tab, create a couple credits. - Go to the 'Pay fines' => SUCCESS: 'Apply credits' button is displayed - Click on 'Apply credits' => SUCCESS: Outstanding credits have been used to pay up debts. - Play with different options (credit excedes debts and vice-versa, they match, etc) => SUCCESS: They all work as expected - Sign off :-D Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82712|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82758&action=edit Bug 18805: Add ability to use up account credits This patch introduces a new button in the 'Pay fines' tab on the patron's account page. This button, labeled 'Normalize account' is only displayed when outstanding credits are available, that could be used to pay up existing debts. When clicking the button, the Koha::Account::normalize_balance method (bug 21896) is used for the purpose. To test: - Apply this patch (on top of 21896) - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than one) - Go to the 'Pay fines' tab => SUCCESS: No 'Apply credits' button is displayed. - On the 'create manual credit' tab, create a couple credits. - Go to the 'Pay fines' => SUCCESS: 'Apply credits' button is displayed - Click on 'Apply credits' => SUCCESS: Outstanding credits have been used to pay up debts. - Play with different options (credit excedes debts and vice-versa, they match, etc) => SUCCESS: They all work as expected - Sign off :-D Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82816&action=edit [18.05.x] Bug 18805: Add ability to use up account credits This patch introduces a new button in the 'Pay fines' tab on the patron's account page. This button, labeled 'Normalize account' is only displayed when outstanding credits are available, that could be used to pay up existing debts. When clicking the button, the Koha::Account::normalize_balance method (bug 21896) is used for the purpose. To test: - Apply this patch (on top of 21896) - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than one) - Go to the 'Pay fines' tab => SUCCESS: No 'Apply credits' button is displayed. - On the 'create manual credit' tab, create a couple credits. - Go to the 'Pay fines' => SUCCESS: 'Apply credits' button is displayed - Click on 'Apply credits' => SUCCESS: Outstanding credits have been used to pay up debts. - Play with different options (credit excedes debts and vice-versa, they match, etc) => SUCCESS: They all work as expected - Sign off :-D Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21915 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Wendy Sharkey <catalog@bfli.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catalog@bfli.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch add an `Apply release notes| |Credits` button to the | |accounts interface to allow | |a librarian to apply | |outstanding credits against | |outstanding debits. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #30 from Jesse Maseto <jesse@bywatersolutions.com> --- Will not be backported to 18.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |deepakkv10@gmail.com --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 14672 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.