[Bug 31653] New: jQuery upgrade broke search button hover effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Bug ID: 31653 Summary: jQuery upgrade broke search button hover effect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 29155 Created attachment 141083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141083&action=edit Gif showing the intended behavior When we upgrade jQuery I missed an instance of deprecated code: "hover" is no longer an alias for "mouseenter mouseleave" when used with on(). Instead of... $("a").on("hover", function... ...we must use... $("a").on("mouseenter mouseleave", function... This change broken the hover action which is supposed to be triggered when the user's mouse interacts with the "Search" button in the header menu. See attached gif. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 [Bug 29155] Upgrade jquery version to 3.6.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 141087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141087&action=edit Bug 31653: Correct event names passed to jQuery on() function This patch replaces the obsolete .on("hover") with .on("mouseenter mouseleave"). This will allow the code to work again following the last jQuery upgrade. See Bug 20217 for discussion of the original implementation: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217#c14 To test, apply the patch and go to the staff interface. Hover your mouse over the "Search" link in the header menu. The adjacent dropdown menu button should have its hover state triggered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141087|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 141088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141088&action=edit Bug 31653: Correct event names passed to jQuery on() function This patch replaces the obsolete .on("hover") with .on("mouseenter mouseleave"). This will allow the code to work again following the last jQuery upgrade. See Bug 20217 for discussion of the original implementation: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217#c14 To test, apply the patch and go to the staff interface. Hover your mouse over the "Search" link in the header menu. The adjacent dropdown menu button should have its hover state triggered. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Trivial fix, works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141088|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141089&action=edit Bug 31653: Correct event names passed to jQuery on() function This patch replaces the obsolete .on("hover") with .on("mouseenter mouseleave"). This will allow the code to work again following the last jQuery upgrade. See Bug 20217 for discussion of the original implementation: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217#c14 To test, apply the patch and go to the staff interface. Hover your mouse over the "Search" link in the header menu. The adjacent dropdown menu button should have its hover state triggered. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141089|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141090&action=edit Bug 31653: Correct event names passed to jQuery on() function This patch replaces the obsolete .on("hover") with .on("mouseenter mouseleave"). This will allow the code to work again following the last jQuery upgrade. See Bug 20217 for discussion of the original implementation: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217#c14 To test, apply the patch and go to the staff interface. Hover your mouse over the "Search" link in the header menu. The adjacent dropdown menu button should have its hover state triggered. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on 29155 and new jQuery version. not relevant to 21.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31653 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org