[Bug 10261] New: On pay fines tab patron tabs are missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Bug ID: 10261 Summary: On pay fines tab patron tabs are missing Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: cgi-bin/koha/members/pay.pl?borrowernumber=96 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com If you're on the pay fines tab you don't see the following tabs on the left as you should: Files Routing List Statistics -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.10 |master Summary|On pay fines tab patron |Link to patron files |tabs are missing |missing from circ-menu.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18209&action=edit Bug 10261 - Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- See Bug 9917 for the solution to the problem with the routing lists link. I can't reproduce the problem with the statistics link in master or 3.10.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- The link is there now but the link doesn't include the borrowernumber so it doesn't open right: /cgi-bin/koha/members/files.pl?borrowernumber= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18209|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18248&action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18248|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18249&action=edit [SIGNED-OFF]Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I never understand why 2 includes files are present. What is the way to keep just one of them? The patch fixes the described issue. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18249|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18306&action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #6)
QA comment:
I never understand why 2 includes files are present. What is the way to keep just one of them?
I would agree that moving towards DRY (don't repeat yourself) would nice. Regardless, I've pushed this to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #6)
I never understand why 2 includes files are present. What is the way to keep just one of them?
From the original commit of that file: "Adds a version of the include circ-menu.inc as circ-menu.tt this has the same functionality as the old include but does not require all the borrowers attributes to be passed as global scoped variables."
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=507c7f422485... Perhaps there is a better way to handle the scope issue? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org