https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 156552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156552&action=edit Bug 34985: Add a quantity field to the manual invoice form This patch add a Quantity field and a Cost field to the manual invoice form this will allow to automatically multiply the amount when it has a default amount. Test plan: 1) Apply the patch 2) Create multiple charge types some with default amount and some without default amount 1-1) Go to Administraion -> Debit types 1-2) Click on New Debit types 1-3) Fill the form check the "Can be manually invoiced?" field 1-5) Click on save 3) Create a manual invoice 2-1) Find a patrons 2-2) Click on Accounting tab 2-3) Click on Create manual invoice tab 2-4) Select a type with default amount set ->Cost field and Quantity field should be added to the form 2-5) Edit the Cost field or Quantity field ->The amount will be automatically calculate 2-6) Select a type with no default amount set ->Cost field and Quantity field should not be added to the form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #3 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 156559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156559&action=edit NoDefaultValue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #5 from Kristi <kkrueger@cuyahogalibrary.org> --- "2-6) Select a type with no default amount set ->Cost field and Quantity field should not be added to the form" Just to clarify here, these fields are present in the form, but if no default value is set for the Debit Type, the cost is listed as 0.00, and the quantity is 1. See screenshot 34985_NoDefault.PNG This does not seem like problematic behavior, but wanted to call it out. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we add a hint to the debit types page? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156561|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158365&action=edit Bug 34985: Add a quantity field to the manual invoice form This patch add a Quantity field and a Cost field to the manual invoice form this will allow to automatically multiply the amount when it has a default amount. Test plan: 1) Apply the patch 2) Create multiple charge types some with default amount and some without default amount 1-1) Go to Administraion -> Debit types 1-2) Click on New Debit types 1-3) Fill the form check the "Can be manually invoiced?" field 1-5) Click on save 3) Create a manual invoice 2-1) Find a patrons 2-2) Click on Accounting tab 2-3) Click on Create manual invoice tab 2-4) Select a type with default amount set ->Cost field and Quantity field should be added to the form 2-5) Edit the Cost field or Quantity field ->The amount will be automatically calculate 2-6) Select a type with no default amount set ->Cost field and Quantity field should not be added to the form Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch add a quantity release notes| |field and a cost field to | |the manual invoice form. | |This allows to | |automatically multiply the | |amount. The new fields will | |display and calculate when | |the selected debit has a | |default cost set. -- You are receiving this mail because: You are watching all bug changes.