[Bug 6880] New: Reason for suggestions do not save
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Bug #: 6880 Summary: Reason for suggestions do not save Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org On master you can add a reason for suggestion in OPAC and in acquisitions when creating a suggestion. This value is not saved into the database. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6070 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 15:36:38 UTC --- mmm... just checked on 3.6.0 and it works fine for me. Anything in the logs ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 15:49:25 UTC --- Retesting now... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 15:55:45 UTC --- I can still reproduce this. 1) Create suggestion in OPAC 2) Fill out title and select a reason from the pull down field 3) Check suggestion in database and in acq - reason is not saved or shown Error logs show no errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 16:04:21 UTC --- well, I just tried by selecting a suggestion or entering one manually, and it worked fine. I also tried by creating a suggestion from both OPAC and staff. Do you have an error in your logs ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 16:25:23 UTC --- Feature was implemented as Bug 1883. I am not sure where the patron reason should save to - there is suggestions.reason - but perhaps this should only be used for accept/reject reaosns from staff? That way the patron reason would not be overwritten. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |oleonard@myacpl.org --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-10-26 16:48:03 UTC --- My guess is that when working on Bug 1883 I modified my database to add a "patronreason" column to the suggestions table. With that in place the feature works. I'll submit a follow-up which makes the table modification. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-10-26 18:20:30 UTC --- Created attachment 6066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6066 Proposed fix The fix for Bug 1883 seems to have lacked the necessary update to the database to add the "patronreason" column to the suggestions table. This patch does so. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6066|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 22:33:12 UTC --- Created attachment 6068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6068 [SIGNED-OFF] Bug 6880- Reason for suggestions do not save The fix for Bug 1883 seems to have lacked the necessary update to the database to add the "patronreason" column to the suggestions table. This patch does so. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch adds database update and change to kohastructure. After this patch is applied, the patron's reason for making a suggestion (form in opac) is saved to the database correctly. The reason is also shown in the detail view of the suggestion. This needs to be backported to 3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 15:17:21 UTC --- *** Bug 6856 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch Status|Signed Off |Passed QA QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-23 15:23:32 UTC --- QA Comment: Code looks good. Patch passed QA. Some developers may have the column already somehow, but will not be troubled by the SQL error if an update tries to add it again. (This could have been checked [very] theoretically.) In the print statement in updatedatabase the bug report number could be mentioned for more information. The whole update procedure is under change now and I suspect that this patch therefore will be on hold until the new system is in place. (Effectively creating the need for a rebase..) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-23 15:35:37 UTC --- Or will be applied to 3.6 and require a new patch for master... thx for QA Marcel, we will wait and find out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6880 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 16:15:29 UTC --- patch pushed, please test (DB rev 3.6.3.001) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org