https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Consistent classes for |Consistent classes for |primary buttons: |primary buttons: Labels |Circulation | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143081&action=edit Bug 32085: Consistent classes for primary buttons: Labels This patch makes changes the button markup in label-creation templates -- including the barcode image generator -- so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view label-related pages to confirm that everything looks correct. In most cases there are no visible changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker) 1. These change the label templates accessed from Cataloging > Tools > Label creator Barcode image generator Quick spine label creator 2. I struggled on the best way to test these changes. In the end, I: . Reviewed the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"... . Listed the templates in koha-tmpl/intranet-tmpl/prog/en/modules/labels/files and split into two lists - those changed and those not changed . Worked out how to access them . Created screenshots and put them in a document (I haven't attached this, but am happy to) . Applied the patch (+ flush_memcached, restart_all, and cleared browser cache) . Went through list of files again: compared to original screenshot taken, then noted whether changed or not . Noted any questions - don't affect the sign off for this bug 3. Files changed: - barcode-print.tt (No change. Barcode image generator) > 39999000011111 > Show barcode) - label-bib-search.tt (note: couldn't figure out where this is used from - no results except .po files from "git grep label-bib-search.tt" (git grep label-bib-search.tt ":(exclude)*.po" shows no results)) - label-edit-layout.tt (No change. Label creator > New > Layout) - label-edit-profile.tt (No change. Label creator > New > Printer profile) - label-edit-range.tt (Changed - now orange colour. Label creator > New > Barcode range) - label-edit-template.tt (No change. Label creator > New > Label template) - label-print.tt (No changes. Called from . labels/label-print.pl (Label creator > New > Label batch > [add some barcodes or item numbers] > Add items > select and use any of the export options) . labels/spinelabel-print.pl (Quick spine label creator > [Enter a barcode for an item with a call number] > pop up window with noptions to "Print this label" and "Edit this label")) - search.tt (No change. Label creator > New > Label batch > [leave Add by barocde(s) or itemnumbers field blank] > enter search criteria > Search) (called from label-item-search.pl) - spinelabel-home.tt (No change. Quick spine label creator > 39999000011111 > View spine label) 4. Files not changed: - label-edit-batch.tt (Label creator > New > Label batch) - label-home.tt (Label creator) - label-manage.tt (Any of the options for Label creator > Manage) - result.tt (called from label-item-search.pl - see search.tt) - spinelabel-print.tt (result window from spinelabel-home.tt (Quick spine label creator > 39999000011111 > View spine label) 5. File count check: - Number of files in folder: 14 - Number of files listed: 14 Questions: 1. Should the buttons be in the div or outisde the div? Those in the white background are: - Barcode image generator - Quick spine label creator 2. I couldn't figure out where label-bib-search.tt is used from - looks like it is not used anywhere. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143152|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143289&action=edit Bug 32085: Consistent classes for primary buttons: Labels This patch makes changes the button markup in label-creation templates -- including the barcode image generator -- so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view label-related pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.