[Bug 15099] New: Fix file name: categorie.pl should be either category.pl or categories.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Bug ID: 15099 Summary: Fix file name: categorie.pl should be either category.pl or categories.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I keep stumbling over categorie.pl... it would be nice to fix the file name to be either category.pl or categories.pl :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45308&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #1)
Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before).
I don't understand why an Apache rewrite rule is needed, and why it should be required that admin/categorie.pl continues to work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frédéric Demians from comment #2)
(In reply to Jonathan Druart from comment #1)
Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before).
I don't understand why an Apache rewrite rule is needed, and why it should be required that admin/categorie.pl continues to work.
To avoid 404 using old links (from the browser history for instance). But indeed, it could be removed if needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> ---
To avoid 404 using old links (from the browser history for instance). But indeed, it could be removed if needed.
I would feel more comfortable signing this patch without the rewrite rule. Just because Koha code has already its load of idiosyncrasies whose reasons are lost in immemorial time... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45308|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45494&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Here it is! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45494|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45495&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No reference to categorie.pl anywhere in the code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45495|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45627&action=edit [PASSED QA] Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No reference to categorie.pl anywhere in the code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45627|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46090&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No reference to categorie.pl anywhere in the code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46094&action=edit Bug 15099 [QA Followup] - Make bug pass koha-qa.pl Cleaned up additional tab characters and such well. This is a very good time to take care of these. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org