[Bug 20413] New: Remove the "template" system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Bug ID: 20413 Summary: Remove the "template" system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.boisson@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This was meant to allow us to have different templates on the staff interface, but this will probably never be used. Could we get rid of the system preference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This also allows for local customization. I see no reason to kill it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- More so, we have even one library using the feature displayed on Hea. https://hea.koha-community.org/systempreferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #1)
This also allows for local customization. I see no reason to kill it.
Staff templates are highly complex. Customization can be made but with CSS and JS or patch on source code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, but if someone really wants to do it, this is a clean way and it's obviously used by a library right now. IIRC you can even just add a few changed templates and it will use the others from the standard template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #5 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- I'll admit i'm not good enough with the technical aspects here, but i think that having separate templates will make your upgrades quite difficult. I am not sure having the system preference makes it that much more simple than managing this with git, and if you're going to have your own templates, you should definitely be using git. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I would say that the library does, where git does not necessary mean a git installation, but can also be self built packages. With the option to switch to standard templates anytime, it's a cleaner and less dangerous way. Also less conflicts. Why are you so set on killing it? The library can not even break something accidentally with it existing? And it will make it much easier if we ever want to implement new templates for Koha as we did with the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Yes, but if someone really wants to do it, this is a clean way and it's obviously used by a library right now. IIRC you can even just add a few changed templates and it will use the others from the standard template.
I'm not sure about that. I tested it recently and it seems you have to copy at least all static files (js, css, images, ...) for the new theme to work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- We have clients using it, so this negates the it will never be used reason to remove it. So there's no real reason to remove it so please don't. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #9 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Well i'm not set on killing it, i'm only trying to see if we could prune Koha from some of it's 500+ system preferences, it sounds like this one is not a good candidate after all. I'd be curious to see exactly how this is put to use though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Why not move to koha-conf.xml ? There is already related infos like opachtdocs, intrahtdocs and includes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Because there is value in being able to switch quickly for testing. And it being a pref means easy statistics with Hea. I don't think we win anything by moving it apart from hiding the feature further. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org