https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Possibly related

From https://datatables.net/faqs/index

Q. My events don't work on the second page A. When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table. To overcome this, simply use jQuery delegated event listener options, as shown in this example. Additionally, you could use my Visual Event bookmarklet to help debug event issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 119865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119865&action=edit Bug 28170: Fix upload.tt search result buttons for page two onwards

From https://datatables.net/faqs/index

"When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table." Before this patch, there were three non-functional buttons on upload search result page, "+ Choose", "Download" and "Delete". This patch binds the handlers to a static element so that the three buttons in upload.tt on page two onwards are functional again. To test: 1. This test is for the "Download" and "Delete" buttons 1.1. Before applying patch, go to cgi-bin/koha/tools/upload.pl 1.2. Make sure you have at least 21 files uploaded 1.3. Perform a search via "Search term" form so that at least 21 results are returned (e.g. a dot (.) as the search term should return all files with filetype) 1.4. Press "Download" and "Delete" for the first result row, it should work as expected (no need to actually delete the file - as long as it pops up a confirmation, it works as expected) 1.5. Go to page 2 of results 1.6. Press "Download" and "Delete" for the first result in page 2 1.7. Observe nothing happening 1.8. Apply patch 1.9. Repeat steps 3-6 1.10. Observe buttons working as expected 2. This test is for the "+ Choose" button 2.1. Go to cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=856&frameworkcode=#subufield 2.2. Under "Other options (choose one), for "Plugin", select "upload.pl" 2.3. Find a biblio and click Edit Record 2.4. Go to 856$u and click "Upload" 2.5. Repeat steps 1.1. - 1.10., but this time for the "+ Choose" button -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119865|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119905&action=edit Bug 28170: Fix upload.tt search result buttons for page two onwards

From https://datatables.net/faqs/index

"When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table." Before this patch, there were three non-functional buttons on upload search result page, "+ Choose", "Download" and "Delete". This patch binds the handlers to a static element so that the three buttons in upload.tt on page two onwards are functional again. To test: 1. This test is for the "Download" and "Delete" buttons 1.1. Before applying patch, go to cgi-bin/koha/tools/upload.pl 1.2. Make sure you have at least 21 files uploaded 1.3. Perform a search via "Search term" form so that at least 21 results are returned (e.g. a dot (.) as the search term should return all files with filetype) 1.4. Press "Download" and "Delete" for the first result row, it should work as expected (no need to actually delete the file - as long as it pops up a confirmation, it works as expected) 1.5. Go to page 2 of results 1.6. Press "Download" and "Delete" for the first result in page 2 1.7. Observe nothing happening 1.8. Apply patch 1.9. Repeat steps 3-6 1.10. Observe buttons working as expected 2. This test is for the "+ Choose" button 2.1. Go to cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=856&frameworkcode=#subufield 2.2. Under "Other options (choose one), for "Plugin", select "upload.pl" 2.3. Find a biblio and click Edit Record 2.4. Go to 856$u and click "Upload" 2.5. Repeat steps 1.1. - 1.10., but this time for the "+ Choose" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119905|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 120328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120328&action=edit Bug 28170: Fix upload.tt search result buttons for page two onwards

From https://datatables.net/faqs/index

"When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table." Before this patch, there were three non-functional buttons on upload search result page, "+ Choose", "Download" and "Delete". This patch binds the handlers to a static element so that the three buttons in upload.tt on page two onwards are functional again. To test: 1. This test is for the "Download" and "Delete" buttons 1.1. Before applying patch, go to cgi-bin/koha/tools/upload.pl 1.2. Make sure you have at least 21 files uploaded 1.3. Perform a search via "Search term" form so that at least 21 results are returned (e.g. a dot (.) as the search term should return all files with filetype) 1.4. Press "Download" and "Delete" for the first result row, it should work as expected (no need to actually delete the file - as long as it pops up a confirmation, it works as expected) 1.5. Go to page 2 of results 1.6. Press "Download" and "Delete" for the first result in page 2 1.7. Observe nothing happening 1.8. Apply patch 1.9. Repeat steps 3-6 1.10. Observe buttons working as expected 2. This test is for the "+ Choose" button 2.1. Go to cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=856&frameworkcode=#subufield 2.2. Under "Other options (choose one), for "Plugin", select "upload.pl" 2.3. Find a biblio and click Edit Record 2.4. Go to 856$u and click "Upload" 2.5. Repeat steps 1.1. - 1.10., but this time for the "+ Choose" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.