[Bug 23145] New: Confirming transfer during checkin clears the table of previously checked-in items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Bug ID: 23145 Summary: Confirming transfer during checkin clears the table of previously checked-in items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: cbrannon@cdalibrary.org, gmcharlt@gmail.com, kyle.m.hall@gmail.com, testopia@bugs.koha-community.org Depends on: 21346 Target Milestone: --- Following the changes made by Bug 21346, transfers triggered during checkin result in a modal dialog asking for confirmation. When this confirmation is clicked the page reloads and the table of previously checked-in items disappears. The information in that table can be very important to librarians keeping track of what they've checked in or as a way to navigate directly to an item or patron. The modal should be dismissed without reloading the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- The specific issue I see is that the first time a transfer is triggered "#item-transfer-modal" is triggered and when you clear it, the check-in table reloads as expected. If an item that is already in transit is checked in, the modal that's triggered is "#wrong-transfer-modal" and when you clear this modal, the check-in table is completely cleared. So it's the second case that creates the problem for our staff. George -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to George Williams (NEKLS) from comment #1)
If an item that is already in transit is checked in, the modal that's triggered is "#wrong-transfer-modal" and when you clear this modal, the check-in table is completely cleared.
Yes, that's right. Thank you for clarifying. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91559&action=edit Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 [Bug 23328] Some check-in messages should be dismissable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91574&action=edit Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Test all the actions when checking in an item which is already in transit: OK, Print transfer slip, and Cancel transfer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91574|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 91610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91610&action=edit Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Test all the actions when checking in an item which is already in transit: OK, Print transfer slip, and Cancel transfer. Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91610|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91622&action=edit Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Test all the actions when checking in an item which is already in transit: OK, Print transfer slip, and Cancel transfer. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org