[Bug 20729] New: Update style of datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Bug ID: 20729 Summary: Update style of datepickers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose and update to the styling of form fields which are configured to use the jQueryUI datepicker plugin. Instead of appending a calendar icon to the input (which can result in unwanted line-wrapping), we can style the input with the calendar icon as a background-image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75166&action=edit Screenshot showing the calendar icon pushed onto the next line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75167&action=edit Screenshot showing the form after this style update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75168&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75168|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75182&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar NOTE: Obvious in Serials. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75182|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75232&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks uglier for me, at least when editing a patron: https://screenshots.firefox.com/yo0iX4PG4RacDzOX/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think there are few places in Koha where a datepicker field has the same width as all form fields around it. I think the only global CSS applied to input widths is for form fields in sidebar filter forms. The alternative is to remove the CSS padding property and modify all templates with datepickers in order to ensure that the "size" attribute of the input field is large enough to accommodate the calendar icon without overlapping the input text. I think that's a less desirable solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
Looks uglier for me, at least when editing a patron:
https://screenshots.firefox.com/yo0iX4PG4RacDzOX/pro.kohadev.org
I would not say that it is ugly. Just a bit funny at first. I would not object to this change if it fixes the line wrap problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75232|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80368&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch, rebuild the staff client CSS file, and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80368|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 83478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83478&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch, rebuild the staff client CSS file, and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83478|0 |1 is obsolete| | --- Comment #11 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 83830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83830&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch, rebuild the staff client CSS file, and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83830|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83851&action=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch, rebuild the staff client CSS file, and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org