[Bug 17322] New: Translation breaks opac-ics.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Bug ID: 17322 Summary: Translation breaks opac-ics.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr File opac-ics.tt is broken in translations. First line says: [% First line will be summary, second line will be description. Avoid indenting. -%] However, in pootle everything is on one line, and ics won't work on translated pages. %s %s %s is overdue Your copy of %s (barcode %s) is overdue %s %s is due Your copy of %s (barcode %s) is due back at the library today %s See: http://lists.koha-community.org/pipermail/koha-translate/2016-September/0025... Workaround: Insert newline character directly into the translation. http://lists.koha-community.org/pipermail/koha-translate/2016-September/0026... Related to Bug 5456 - Create a link to opac-ics.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5456 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 [Bug 5456] Create a link to opac-ics.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 55718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55718&action=edit Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55718|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55733&action=edit Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55733|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55798&action=edit [PASSED QA] Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17322 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org