[Bug 35511] New: Add visual indicators of patron edit form collapsible sections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Bug ID: 35511 Summary: Add visual indicators of patron edit form collapsible sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, koha-bugs@lists.koha-community.org, testopia@bugs.koha-community.org Depends on: 35510 On the patron add/edit form there is no visible sign that the heading of each section is clickable other than the cursor change. I think adding some style there will help avoid accidentally clicking the heading unintentionally. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160033&action=edit Bug 35511: Add visual indicators of patron edit form collapsible sections This patch updates CSS and markup in the patron add/edit form so that there is better visual indication that sections can be collapsed by clicking headings. The JS function for showing and hiding sections has also been updated to reduce verbosity. Unrelated markup change for the sake of accessibility: A <label> has been added to the "Show collapsed fields" checkbox which is seen when CollapseFieldsPatronAddForm is active. To test, apply the patch and go to Patrons -> New patron. - Each section of the form should have an arrow indicator by the section heading indicating whether it is expanded or collapsed. - Mousing over the heading should show a border to help show the clickable region. - Clicking the header should collapse the section and the arrow indicator should change to reflect that the section is collapsed. - Go to Administration -> Sytem preferences and search for CollapseFieldsPatronAddForm. - Make some selections from the dropdown and save your changes. - Return to the patron entry form and confirm that your selections are collapsed by default. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160033|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160087&action=edit Bug 35511: Add visual indicators of patron edit form collapsible sections This patch updates CSS and markup in the patron add/edit form so that there is better visual indication that sections can be collapsed by clicking headings. The JS function for showing and hiding sections has also been updated to reduce verbosity. Unrelated markup change for the sake of accessibility: A <label> has been added to the "Show collapsed fields" checkbox which is seen when CollapseFieldsPatronAddForm is active. To test, apply the patch and go to Patrons -> New patron. - Each section of the form should have an arrow indicator by the section heading indicating whether it is expanded or collapsed. - Mousing over the heading should show a border to help show the clickable region. - Clicking the header should collapse the section and the arrow indicator should change to reflect that the section is collapsed. - Go to Administration -> Sytem preferences and search for CollapseFieldsPatronAddForm. - Make some selections from the dropdown and save your changes. - Return to the patron entry form and confirm that your selections are collapsed by default. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Getting "error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt)." when I try to apply the patch. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160087|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164852&action=edit Bug 35511: Add visual indicators of patron edit form collapsible sections This patch updates CSS and markup in the patron add/edit form so that there is better visual indication that sections can be collapsed by clicking headings. The JS function for showing and hiding sections has also been updated to reduce verbosity. Unrelated markup change for the sake of accessibility: A <label> has been added to the "Show collapsed fields" checkbox which is seen when CollapseFieldsPatronAddForm is active. To test, apply the patch and go to Patrons -> New patron. - Each section of the form should have an arrow indicator by the section heading indicating whether it is expanded or collapsed. - Mousing over the heading should show a border to help show the clickable region. - Clicking the header should collapse the section and the arrow indicator should change to reflect that the section is collapsed. - Go to Administration -> Sytem preferences and search for CollapseFieldsPatronAddForm. - Make some selections from the dropdown and save your changes. - Return to the patron entry form and confirm that your selections are collapsed by default. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164853&action=edit Bug 35511: (follow-up) Tweaks to CSS, adding aria-hidden to icons -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164852|0 |1 is obsolete| | Attachment #164853|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164873&action=edit Bug 35511: Add visual indicators of patron edit form collapsible sections This patch updates CSS and markup in the patron add/edit form so that there is better visual indication that sections can be collapsed by clicking headings. The JS function for showing and hiding sections has also been updated to reduce verbosity. Unrelated markup change for the sake of accessibility: A <label> has been added to the "Show collapsed fields" checkbox which is seen when CollapseFieldsPatronAddForm is active. To test, apply the patch and go to Patrons -> New patron. - Each section of the form should have an arrow indicator by the section heading indicating whether it is expanded or collapsed. - Mousing over the heading should show a border to help show the clickable region. - Clicking the header should collapse the section and the arrow indicator should change to reflect that the section is collapsed. - Go to Administration -> Sytem preferences and search for CollapseFieldsPatronAddForm. - Make some selections from the dropdown and save your changes. - Return to the patron entry form and confirm that your selections are collapsed by default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164874&action=edit Bug 35511: (follow-up) Tweaks to CSS, adding aria-hidden to icons Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37814 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37814 [Bug 37814] Wrong use of __() in .tt files -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org