https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Previously reported on bug 27858: Master_D9 run 1663 11:41:11 koha_1 | [0m[92mKoha::Exceptions::Patron::MissingMandatoryExtendedAttribute[0m { 11:41:11 koha_1 | Parents [92mKoha::Exceptions::Patron[0m 11:41:11 koha_1 | public methods (3) : [92mdescription[0m, [92mFields[0m, [92mtype[0m 11:41:11 koha_1 | private methods (0) 11:41:11 koha_1 | internals: { 11:41:11 koha_1 | [35megid[0m "[93m1000 1000[0m", 11:46:27 koha_1 | [35meuid[0m [94m1001[0m, 11:46:27 koha_1 | [35mgid[0m "[93m1000 1000[0m", 11:46:27 koha_1 | [35mmessage[0m "[93m[0m", 11:46:27 koha_1 | [35mpid[0m [94m4522[0m, 11:46:27 koha_1 | [35mtime[0m [94m1621935671[0m, 11:46:27 koha_1 | [35mtrace[0m [92mDevel::StackTrace[0m, 11:46:27 koha_1 | [35mtype[0m "[93mVfu0SZ[0m", 11:46:27 koha_1 | [35muid[0m [94m1001[0m 11:46:27 koha_1 | } 11:46:27 koha_1 | } 11:46:27 koha_1 | Missing mandatory extended attribute (type=Vfu0SZ) at /kohadevbox/koha/Koha/Patrons/Import.pm line 420, <$fh> line 2. 11:46:27 koha_1 | 11:46:27 koha_1 | # Failed test at t/db_dependent/Koha/Patrons/Import.t line 902. 11:46:27 koha_1 | # got: '0' 11:46:27 koha_1 | # expected: '1' 11:46:27 koha_1 | # Looks like you planned 17 tests but ran 1. 11:46:27 koha_1 | # Looks like you failed 1 test of 1 run. 11:46:27 koha_1 | 11:46:27 koha_1 | # Failed test 'patron_attributes' 11:46:27 koha_1 | # at t/db_dependent/Koha/Patrons/Import.t line 1114. 11:46:27 koha_1 | Can't call method "extended_attributes" on an undefined value at t/db_dependent/Koha/Patrons/Import.t line 905, <$fh> line 2. ----- Got it locally t/db_dependent/Koha/Patrons.t ........................................... 28/42 # No tests run! # Failed test 'No tests run for subtest "extended attributes"' # at t/db_dependent/Koha/Patrons.t line 1770. # Looks like you failed 1 test of 110. t/db_dependent/Koha/Patrons.t ........................................... 33/42 # Failed test 'Test Koha::Patrons::merge' # at t/db_dependent/Koha/Patrons.t line 1774. Missing mandatory extended attribute (type=hGA0QWrb6)# Looks like your test exited with 2 just after 33. ----- Master_D9_My8 586 Docker_7 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121631&action=edit Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1 TestBuilder will generate an integer for the Koha::Patron::Attribute::Type object, but if 1 is picked some tests are failing randomly At least t/db_dependent/Koha/Patrons.t and t/db_dependent/Koha/Patrons/Import.t The expection "Missing mandatory extended attribute" is raised when the patron is stored. Test plan: The following script should return 0 when the patch is applied: """ use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my $x = $builder->build_object( { class => 'Koha::Patron::Attribute::Types', } ); say $x->mandatory; """ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Will also fix 13:40:55 koha_1 | # Failed test 'No tests run for subtest "extended attributes"' 13:40:55 koha_1 | # at t/db_dependent/Koha/Patrons.t line 1770. 13:40:55 koha_1 | # Looks like you failed 1 test of 110. 13:40:55 koha_1 | 13:40:55 koha_1 | # Failed test 'Test Koha::Patrons::merge' 13:40:55 koha_1 | # at t/db_dependent/Koha/Patrons.t line 1774. 13:40:55 koha_1 | Missing mandatory extended attribute (type=cX9Fk5KL)# Looks like your test exited with 11 just after 33. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.