https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Unable to reproduce when upgrading k-t-d from 22.05.x to 23.11.x, that particular db rev runs without issue. @Pablo are you able to run the following scripts and check their output (before upgrade): misc/maintenance/search_for_data_inconsistencies.pl misc/maintenance/audit_database.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Pablo AB from comment #3)

@Pedro, after ~8', the output of search_for_data_inconsistencies.pl was:

``` == Items do not have itype defined == * Item with itemnumber=39024 does not have a itype value, additionally no item type defined for biblionumber=22362 [7 similar lines] => The system preference item-level_itypes expects item types to be defined at item level ```

Are you sure this version should have `audit_database.pl`? Is not there.

BTW, `perldoc search_for_data_inconsistencies.pl` return a malformed output.

You're right, apologies. audit_database.pl was added by bug 34064 in version 23.11, although you likely would be able to backport it for this specific use case. Looking at 220600078.pl, what you could do, before upgrading, is manually check the output of SHOW CREATE TABLE reserves; SHOW CREATE TABLE old_reserves; SHOW CREATE TABLE item_groups; and compare that with what's in kohastructure.sql. This may provide some clues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Bug 24857 is adding the table item_groups. This is DBrev 220600014. Bug 24860, the one you report failing for you, it's DBrev 220600078. Both bugs were added for 22.11. It appears, for some reason, your schema ended up without the item_groups table, and that should exist by the time DBrev 220600078 runs. What's the full output of updatedatabase when you perform the update? Does bug 24857 DBrev 220600014 run? Does the message 'Added new table 'item_groups'' show? If not, any error (related to 220600014?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #8 from Pablo AB <pablo.bianchi@gmail.com> --- In the broken state `SHOW CREATE TABLE item_groups;` also.. ERROR 1146 (42S02): Table 'koha_myinstance.item_groups' doesn't exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pablo: can you share your DB structure? There's a mysqldump option for that. Otherwise the exchange is difficult to follow. Thanks in advance! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Version|Main |23.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #13 from Pablo AB <pablo.bianchi@gmail.com> --- Created attachment 167670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167670&action=edit Schema of the DB, with mysqldump --no-data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #15 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Pablo, can you try the upgrade again, and copy everything in the output starting from Upgrading database schema for myinstance until the error appears? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #17 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for sharing your apt upgrade output, Pablo. It seems like your system didn't roll back all the way after one of the previous upgrade attempts - your database upgrade started at 22.06.00.041, but it should have started at 22.06.00.000. That would explain why your system doesn't have the item_groups table, since it skipped that part of the upgrade. You might need to try backing up your data and importing into a fresh install, but there might be other options - I'm not an expert on upgrading. I'd suggest asking around on the Koha community chat (https://chat.koha-community.org/), or on the mailing lists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pablo AB from comment #18)

I asked on chat, https://chat.koha-community.org/koha-community/pl/drr98y7z13dqxj8mrpjbj8f6je giving more details. The issue happen on two instances on two different hosts, one of them a production server which I never tried to upgrade out of 22.05.x. I have no clue why I did get to have a .06/development and a 040. The other host/instance (test/sandbox) have the same strange version.

Not sure also how to solve it either. Just an UPDATE to version, changing the `22.0600040` to `22.0500000`? All the schema upgrades are idempotent?

It seems that it's just me, so maybe this bug should be closed.

You could take a backup and try that. The database updates should be idempotent. Important bit is to really pay attention on the output of the update script to see where it gets stuck and resolve any issues found before continuing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #21 from Pablo AB <pablo.bianchi@gmail.com> --- Created attachment 168403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168403&action=edit apt upgrade output after changing version to 22.0500000 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168446&action=edit Bug 36424: Remove trailing comma -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #25 from Pablo AB <pablo.bianchi@gmail.com> ---

Are you able to test my latest patch for this use case? I believe there is an extra trailing comma in the db rev.

I also saw that trailing comma, since it seems to break on that query, and all variables are defined and with its contents. Removing the comma it runs the query, but breaks on the next query, `ALTER TABLE $rooms_table RENAME INDEX..`.

Also, can you confirm if the Koha system this is happening on has the following plugin installed: https://github.com/bywatersolutions/koha-plugin-room-reservations

Yes! It is installed: - Name: Room Reservations Plugin ENABLED - Description: This plugin provides a room reservation solution on both intranet and OPAC interfaces. - Author: Lee Jamison - Plugin version: 3.2.1 - Minimum Koha version: 3.22 - Last updated: 22/08/2022 Should be disabled/removed before the upgrade? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Pablo AB from comment #26)

Breaks on RENAME TABLE query on 230600061.pl, but removing the comma (line 5 on the query), then on the first ALTER TABLE. Maybe should be an IF EXIST or DROP TABLEs?

How do we know it's then breaking on the first ALTER TABLE? What's the error? (In reply to Pablo AB from comment #25)

Should be disabled/removed before the upgrade?

That plugin creates and utilizes a database table called 'bookings'. The DB REV we're discussing here is renaming that table if it already exists, because the table added in bug 29002 is also named 'bookings'. In theory, if you uninstall that plugin: https://github.com/bywatersolutions/koha-plugin-room-reservations/blob/maste... It should remove all plugin related tables and then the DB rev will no longer consider renaming anything because 'bookings' will not exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #28)

I checked out branch 23.05.x (previous to bookings bug 29002) I installed bywater's bookings plugin version 3.2.1 (when it was still using table named 'bookings'. I ran the db rev, it errored, I applied my patch, it no longer errors and finishes successfully:

kohadev-koha@kohadevbox:koha(23.05.x)$ updatedatabase Migrated room reservations plugin to it's own namespace You MUST upgrade to the latest room reservation plugin to continue using it Plugin disabled, please re-enable once you have upgraded it DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/test_29002.pl [09:36:21]: Bug 29002 - Add bookings table Added new table 'bookings' Added column 'items.bookable' Added column 'deleteditems.bookable' Added new permission 'manage_bookings'

@Katrin the patch "Bug 36424; Remove trailing comma" is still required.

Thanks Pedro - easiest way to get my attention is to set back to PQA - it shows up in my list that way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11 released in| | Status|Passed QA |Pushed to main --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... not a real follow-up. Sorry, got a little confused here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I want to update this bug's title to mention that fix specifically, but wanting on Pablo's reply to my last comments to ensure nothing else is required here and we've isolated the issue successfully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Database update |Database update |22.06.00.078 breaks update |22.06.00.078 breaks due to |process (II) |syntax error Status|Needs Signoff |Signed Off --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think as this has just been reported another time we should go ahead and fix the obvious syntax error. If there are other mistakes, we can put them on a new bug later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)|24.11 |24.11.00,24.11 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Database update |Database update |22.06.00.078 breaks due to |23.06.00.061 breaks due to |syntax error |syntax error --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Katrin I'm changing the bug title to 23.06.00.061 as that is the DB rev with the issue and the one being fixed here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.11 |24.11 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Depends on| |29002, 35473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 [Bug 35473] Core bookings and room reservations plugin tables clash -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #42 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 | CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes a syntax error |This fixes a syntax error release notes|in database update |in database update |230600061.pl (from bug |230600061.pl (from bug |29002 which added the item |29002 which added the item |booking feature to Koha |booking feature to Koha |23.11.) - there was a comma |23.11.) - there was a comma |that shouldn't have been |that shouldn't have been |there, which would cause |there, which would cause |the upgrade to fail. |the upgrade to fail if an | |old version of the | |following plugin was | |installed: | |https://github.com/bywaters | |olutions/koha-plugin-room-r | |eservations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #43 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.