[Bug 40606] New: Remove parentheses and italics from shelving location in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Bug ID: 40606 Summary: Remove parentheses and italics from shelving location in the staff interface Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Now that bug 15461 is in Koha, I noticed that even though the shelving location was moved to its own column, the formatting and parentheses were left. That looks weird now that it's in its own colum. To recreate : 1. Go to a detailed record (make sure it has an item and the item has a shelving location, I used http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=161 --> Note that the shelving location is in parentheses and in italics I noticed that some records show the location without the parentheses already, I'm not sure why some have parentheses and some don't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- OK I think it's the permanent location that makes it have parentheses. I still think the location should not be in italics when it's in its own column. The italics was there to differentiate it from the branch name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove parentheses and |Remove italics from |italics from shelving |shelving location in the |location in the staff |staff interface |interface | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 185158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185158&action=edit Bug 40606: Remove italics from shelving location in the staff interface This patch removes the italics formatting from the shelving location now that it is in its own column. The formatting was there to differentiate the shelving location from the branch name when they were in the same column. This is not necessary anymore. To test : 1. Go to a record with items which have a shelving location. --> The shelving location is in italics 2. Apply patch 3. `yarn build` 4. Refresh the page (Ctrl + F5) --> The shelving location is displayed normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I did a simple change, but I fear it might be too simple...? Nothing in Koha is that easy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 [Bug 15461] Add shelving location to holdings table as a separate column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185158|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185164&action=edit Bug 40606: Remove italics from shelving location in the staff interface This patch removes the italics formatting from the shelving location now that it is in its own column. The formatting was there to differentiate the shelving location from the branch name when they were in the same column. This is not necessary anymore. To test : 1. Go to a record with items which have a shelving location. --> The shelving location is in italics 2. Apply patch 3. `yarn build` 4. Refresh the page (Ctrl + F5) --> The shelving location is displayed normally Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185164|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 185436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185436&action=edit Bug 40606: Remove italics from shelving location in the staff interface This patch removes the italics formatting from the shelving location now that it is in its own column. The formatting was there to differentiate the shelving location from the branch name when they were in the same column. This is not necessary anymore. To test : 1. Go to a record with items which have a shelving location. --> The shelving location is in italics 2. Apply patch 3. `yarn build` 4. Refresh the page (Ctrl + F5) --> The shelving location is displayed normally Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement removes release notes| |the italics formatting from | |the shelving location in a | |record's holdings table, | |now that it is in its own | |column. (The formatting was | |there to differentiate the | |shelving location from the | |library name when they were | |in the same column. This is | |not necessary anymore.) | | | |(This is a follow-up to Bug | |15461 - Add shelving | |location to holdings table | |as a separate column, added | |in Koha 25.04.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #6 from David Nind <david@davidnind.com> --- Something I can QA! QA scripts are happy, works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- But this CSS rule applies on many other places where location is just after library name. For example : koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt Maybe we should add a class to parent with like 'branch-and-location', and apply the CSS rule on that only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Fridolin Somers from comment #9)
But this CSS rule applies on many other places where location is just after library name. For example : koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
Maybe we should add a class to parent with like 'branch-and-location', and apply the CSS rule on that only.
That's what I feared. I figured it was way too simple a change... I fear it's too late for this bug report since it was already pushed and backported. Maybe create a new bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41006 [Bug 41006] Shelving location style changed in many places since Bug 40606 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Opened Bug 41006 @Owen you are the best candidate for this I think ;) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org