[Bug 26299] New: Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Bug ID: 26299 Summary: Help text for OPAC SMS number should be less North American-centric Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org At the moment, the help text on opac-messaging.pl is "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." The first style is a North American style, which looks strange to people from other countries like Australia where we frequently format non-mobile phone numbers like 02 5555 5555 or mobile numbers like 0455 555 555. We should use a more generic style like we do on memberentry.pl when we say "SMS number should be in the format 1234567890 or +11234567890" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 109136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109136&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109136|0 |1 is obsolete| | --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 109183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109183&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Checked and working perfectly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109191&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, are you ok with this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)
Nick, are you ok with this?
Alternatively, we could provide a printf pattern for rendering the numbers in a more localized way I suppose? Seems like Template::Toolkit has a few options on that front. Since the OPAC is public-facing, I could see wanting to make it seem more polished than the Staff Interface... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
Nick, are you ok with this?
I checked with our educators - their concern is that it not start with 1, which is the indicator of 'long distance' calls here. 9785550123 would be better as it won't end up being a real phone number https://en.wikipedia.org/wiki/555_(telephone_number) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #6)
(In reply to Jonathan Druart from comment #4)
Nick, are you ok with this?
I checked with our educators - their concern is that it not start with 1, which is the indicator of 'long distance' calls here.
9785550123 would be better as it won't end up being a real phone number https://en.wikipedia.org/wiki/555_(telephone_number)
That's an interesting point. Maybe we should just change the wording (in both interfaces) to something like... "Please enter numbers only. Prefix the number with + if including the country code." After that, the Javascript validation messages should provide enough formatting information? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- I mention the + in part because I don't think we actually mention that anywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26285 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Cook from comment #7)
(In reply to Nick Clemens from comment #6)
(In reply to Jonathan Druart from comment #4)
Nick, are you ok with this?
I checked with our educators - their concern is that it not start with 1, which is the indicator of 'long distance' calls here.
9785550123 would be better as it won't end up being a real phone number https://en.wikipedia.org/wiki/555_(telephone_number)
That's an interesting point.
Maybe we should just change the wording (in both interfaces) to something like...
"Please enter numbers only. Prefix the number with + if including the country code."
After that, the Javascript validation messages should provide enough formatting information?
I think this is the best solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109191|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109625&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109625|0 |1 is obsolete| | --- Comment #11 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 109667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109667&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexis.ripetti@inLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109667|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109991&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25520 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org