[Bug 29191] New: Linking biblio headings to authorities doesn't work with subdivisoins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Bug ID: 29191 Summary: Linking biblio headings to authorities doesn't work with subdivisoins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org Linking biblio headings to authorities fails if there is subdivision(s) to search. Test plan (Unimarc example): - AutoCreateAuthorities On - BiblioAddsAuthorities On - add a subject in a biblio: 606 $aArt $xHistory => new authority is created - reindex authorities if Zebra search engine - add same subject in an other biblio: 606 $aArt $xHistory => again, a new authority is created Heading helper adds the subdiviion name in the search term. So the entire search query for mathing authorities is "Art generalsubdiv History" I'm looking for a fix, but i need someone to explain me why we add something which is similar to metada in the search term. This is done both for MARC21 and UNIMARC in C4::Heading::UNIMARC::_get_search_heading and C4::Heading::MARC21::_get_search_heading -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 126306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126306&action=edit Bug 29191: Don't include subdivision names in heading search form with Elasticsearch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Elasticsearch QA Contact|testopia@bugs.koha-communit | |y.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Changed the component to Searching - Elasticsearch since it works with Zebra with the correct configuration: authority-koha-indexdefs.xml index the subdivision names in match-heading. I don't know how to make this configurable with Elasticsearch. So here is the quick fix that prevent adding subdivisions in search form for ES. Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jeremy.breuillard@biblibre. | |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is a bug not an enhancement right ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Fridolin Somers from comment #3)
This is a bug not an enhancement right ?
yes. Changed to normal. Thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Linking biblio headings to |Linking biblio headings to |authorities doesn't work |authorities doesn't work |with subdivisoins |with subdivisions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28628 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28203 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |phil@chetcolibrary.org --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- By 2021 you should have had the fix for bug 24269 and thus should have had the subdivision metadata indexed in ES, shouldn't you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Phil Ringnalda from comment #5)
By 2021 you should have had the fix for bug 24269 and thus should have had the subdivision metadata indexed in ES, shouldn't you?
it looks like the mappings weren't updated for UNIMARC. But maybe this would be the preferrable fix here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Mmm, mappings. The point of bug 24269 and bug 25273 was that you cannot do any better than Koha by mapping match-heading, because match-heading is only searched by the linker, and the linker will search for the search_form of the heading, so any mapping other than exactly that can only fail or return worse results. If you don't have any mapping at all for match-heading, then that's perfect, because Koha will build one by calling $heading->search_form and stuffing that into the index. However, I know from having a service-provider-provided mapping file that had outdated mappings for match-heading that if you do have them, they will still be used, and will break things. That's probably where Alex was in 2021, with code that would have indexed headings as "Art generalsubdiv History" but with a match-heading mapping that prevented it from successfully doing so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org