[Bug 35267] New: Add further CSS options for Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Bug ID: 35267 Summary: Add further CSS options for Notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org During review of bug 33487 I made the suggestion that we should have more CSS options for our notices at the system preference level. I've also hit this when looking into bug 30287. So.. recording this here and hopefully we'll find some time to work on it. Personally.. I'd have * EmailNoticeCSS - CSS stored in the DB for email notice CSS * EmailNoticeCSSHosted - Location of CSS file for email notice CSS (to retain the old NoticeCSS option) * PrintNoticeCSS - CSS stored in the DB for print notice CSS * PrintNoticeCSSHosted - Location of the CSS file for the print notice CSS (to reatin the old SlipCSS option) SMS doesn't support HTML/CSS so no need for that transport type to have these CSS options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33478 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30287 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34704 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Correction, it was bug 33478 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 [Bug 30287] Notices using HTML render differently in notices.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add further CSS options for |Clarify CSS options for |Notices |Notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32344 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32345 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32346 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This would be easier to implement if we had continued down the path from bug 31714.. we'd have fewer places to change :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478#c78 is the original comment regarding this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 [Bug 33478] Customise the format of notices when they are printed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org, | |caroline.cyr-la-rose@inlibr | |o.com, | |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172414&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172415&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172416&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. TODO: We still need to apply these more clearly to the printing code, both batch and slip printing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172417&action=edit Bug 35267: Remove printslip css from printnotice This is the begginings of trying to apply styling selectively in the various printing scripts for Koha's notices and slips. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172418&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- There's still more work to do here to make sure we catch all the different printing cases.. but I think this is a solid start. I'd love some help/thoughts on the notice editing UI changes and the relocation of preferences to one place under the 'Tools' section for system preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172414|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172457&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172415|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172458&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172418|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172459&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172416|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172460&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172461&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172462&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172463&action=edit Bug 35267: Migrate notice printing to members/print_notice This migrates the bulk notice printing from tools/print_notice.pl using circ/printslip.tt to members/print_notice.pl using members/print_notice.tt This clarified that we are working on pre-existing notices in the message queue and as such should be applying relevant print/email notice styling and not slip styling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172457|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172474&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172458|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172475&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172459|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172476&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172460|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172477&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172461|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172478&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172462|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172479&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172463|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172480&action=edit Bug 35267: Migrate notice printing to members/print_notice This migrates the bulk notice printing from tools/print_notice.pl using circ/printslip.tt to members/print_notice.pl using members/print_notice.tt This clarified that we are working on pre-existing notices in the message queue and as such should be applying relevant print/email notice styling and not slip styling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- # Test plan This is going to be a fun road to travel. ## UI 1) Apply patches and run database updates 2) Note that 'NoticeCSS' and 'SlipCSS' have been renamed to 'EmailNoticeStylesheet' and 'PrintSlipStylesheet' to better reflect their content and both have been migrated into 'Admin > System preferences > Tools > Notices and slips' 3) Note in the same location in system preferences, we now also have 'EmailNoticeCSS', 'PrintNoticeCSS' and 'PrintSlipCSS' preferences that allow direct entry of CSS rules for their respective notice message transports. 4) Under 'Tools > Notices and Slips', edit a notice and note we have a new accordion near the top of the page that displays the content of 'AllNoticeCSS', 'EmailNoticeCSS', 'PrintNoticeCSS' and 'PrintSlipCSS' preferences for the end users reference 4a) If the user has administrative permissions, they should also see an 'Edit' button that's a shortcut the the relevant preference in the system preferences ## Adding styles 1) Add a simple style for testing to 'AllNoticeCSS' `.alltest { color: red }` 2) Add a simple style for testing to 'EmailNoticeCSS' `.emailtest { color: green }` 3) Add a simple style for testing to 'PrintNoticeCSS' `.printtest { color: organge }` 4) Let use the WELCOME notice for testing.. add a simple html template as follows. ``` <p> This is a notice for testing</br> <span class="alltest">All message transport types should display this red</span><br> <span class="emailtest">Only email notices should display this green</span></br> <span class="printtest">Only print notices should display this orange</span><br> All done </p> ``` 5) Lets use 'Henry A' to test the notice 5a) Do NOT set an email address for Henry 5b) Queue a 'Welcome' print notice using 'More > Send welcome' 5c) Add a primary email address for Henry 5d) Queue a 'Welcome' email notice using 'More > Send welcome' 6) Navigate to the 'Notices' tab for Henry 7) Click the title of the print notice to display a preview and note the correct colors are displayed 8) Click the title of the email notice to display a preview and note the correct colors are displayed ## Testing the functionality 1) Run 'gather_print_notices.pl' with options to output to html file 2) Confirm that the generated notice contains the correct classes and styles 3) Enable 'ManageNotices' preference from the dependency bug 4) Navigate to 'Tools > Mange notices' 5) Select both notices and print using the bottom button 6) Confirm that the two notices display the different colors and are on two separate pages in the print preview. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172474|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172485&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172475|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172486&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172476|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172487&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172477|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172488&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172478|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172489&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172479|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172490&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172480|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172491&action=edit Bug 35267: Migrate notice printing to members/print_notice This migrates the bulk notice printing from tools/print_notice.pl using circ/printslip.tt to members/print_notice.pl using members/print_notice.tt This clarified that we are working on pre-existing notices in the message queue and as such should be applying relevant print/email notice styling and not slip styling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38090 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38090 [Bug 38090] The UX for custom notice styling per notice template is confusing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This clarifies the original Notice and Slip CSS options expanding from just supporting linked stylesheets to using local style input fields too. We do not yet handle clarifying how the per notice per transport type level CSS can be defined. This needs some thought and I've got that as a follow-up bug 38090 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This also, does not fully implement the stylesheet link options for the multi-print handling code.. that was already failing in bug 33260 and will also need some thought.. I think this should also be a follow-up bug as I'm really not sure if anyone is actually using that functionality in real life. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38078 [Bug 38078] Merge /batch/printnotice.tt and /members/print_notice.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172485|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175531&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172486|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175532&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172487|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175533&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172488|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175534&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172489|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175535&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172490|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175536&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|33260 | Blocks| |33260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Bugs reordered and rebased so we don't hold up this important fix/enhancement behind the more contentious notices management page and print options bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- With the reorder the following parts of the above test plan should be ignored.. or rather only tested when the relevant bug is applied atop this one: 3) Enable 'ManageNotices' preference from the dependency bug 4) Navigate to 'Tools > Mange notices' 5) Select both notices and print using the bottom button 6) Confirm that the two notices display the different colors and are on two separate pages in the print preview. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_25_05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com, | |janet.mcgowan@ptfs-europe.c | |om, r.delahunty@arts.ac.uk, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #42 from David Nind <david@davidnind.com> --- After applying the patches, there was an error with the databae update updatedatabase String found where operator expected at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35267.pl line 20, near "$out "Added new system preference 'AllNoticeCSS'"" (Missing operator before "Added new system preference 'AllNoticeCSS'"?) DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35267.pl [23:07:10] ERROR: {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 741. at /kohadevbox/koha/C4/Installer.pm line 743 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175531|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175706&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175532|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175707&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175533|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175708&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175534|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175709&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175535|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175710&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175536|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175711&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175706|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175715&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175707|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175716&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175708|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175717&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175709|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175718&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175710|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175719&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175711|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175721&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175715|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175723&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175716|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175724&action=edit Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175717|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175725&action=edit Bug 35267: Expose style preferences in template editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175718|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175726&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175719|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175727&action=edit Bug 35267: Move JS to bottom in printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175721|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175728&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175729&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Looks like I lost a colon during the patch re-arrangement, thanks for spotting it David :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #63 from David Nind <david@davidnind.com> --- Hi martin. Apologies for taking so long to re-test. The patches no longer apply 8-(... git bz apply 35267 Bug 35267 - Clarify CSS options for Notices 175723 - Bug 35267: Add and Update Notice CSS system preferences 175724 - Bug 35267: Add preferences to UI 175725 - Bug 35267: Expose style preferences in template editor 175726 - Bug 35267: Apply preferences to preview and mailing 175727 - Bug 35267: Move JS to bottom in printslip 175728 - Bug 35267: Migrate accounts_summary to printslip 175729 - Bug 35267: Update unit tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35267: Add and Update Notice CSS system preferences Applying: Bug 35267: Add preferences to UI Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref error: Failed to merge in the changes. Patch failed at 0001 Bug 35267: Add preferences to UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175723|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178485&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175724|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178486&action=edit Bug 35267: Add preferences to UI Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175725|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178487&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175726|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178488&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175727|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178489&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175728|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178490&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175729|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178491&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #71 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #63)
Hi martin.
Apologies for taking so long to re-test.
The patches no longer apply 8-(...
We should be applying again now.. do feel free to reach out on mattermost if you need rebases.. I try to stay on top of things but as you can probably tell from my dashboard I'm trying to track a few hundred outstanding bug submissions in my name so I don't always notice there's been a comment all that quickly. Thanks for your interest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Everything seems to working as described. The difference between PrintSlipCSS and what can be done under the 'Format' tab is that PrintSlipCSS applies to ALL print notices. With the 'Format' tab you can apply CSS to specific notices OR "Apply format settings to all notices:". It all feels a bit overwhelming to me in there now. Maybe we at least need some clearer instructions on what CSS will apply and where? Can something be done with the display? Having accordions for each to only display an 'Edit' button feels off, to me. Maybe combing 'All notice CSS', 'Email Notice CSS', 'Print Notice CSS', and 'Format' in one place with some hints/tips about each would make it easier to understand what does what? With this will we even need to keep the "Apply format settings to all notices:" functionality? Seems like using PrintNoticeCSS will be better. Sorry for being a curmudgeon here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #73 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Lucas Gass (lukeg) from comment #72)
Everything seems to working as described.
The difference between PrintSlipCSS and what can be done under the 'Format' tab is that PrintSlipCSS applies to ALL print notices. With the 'Format' tab you can apply CSS to specific notices OR "Apply format settings to all notices:". It all feels a bit overwhelming to me in there now. Maybe we at least need some clearer instructions on what CSS will apply and where?
Can something be done with the display? Having accordions for each to only display an 'Edit' button feels off, to me. Maybe combing 'All notice CSS', 'Email Notice CSS', 'Print Notice CSS', and 'Format' in one place with some hints/tips about each would make it easier to understand what does what?
With this will we even need to keep the "Apply format settings to all notices:" functionality? Seems like using PrintNoticeCSS will be better.
Sorry for being a curmudgeon here.
Just being picky.... In the 'Format' tab, the CSS will be applied to ALL NOTICE (no matter the transport type) but only when PRINTING them. I find this incredibly confusing personally and it's one of the things I highlight as a bug in bug 38090, bug 33260 and the original bug 33478. I have no idea why the 'Apply format setting to all notices' was ever added to the format tab.. I brought this up on the original bug I believe (as did Marcel) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #74 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Also.. given bug 33478 comment 198 the Format stuff actually in all reality only applies to SLIPS right now ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39203 [Bug 39203] Remove checkbox to Apply format settings to all notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178485|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180574&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178486|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180575&action=edit Bug 35267: Add preferences to UI Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178487|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180576&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178488|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180577&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178489|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180578&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178490|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180579&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178491|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180580&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #82 from David Nind <david@davidnind.com> --- You might want to change the Sponsored-by line :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180574|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180963&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180575|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180964&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180576|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180965&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180577|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180966&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180578|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180967&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180579|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180968&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180580|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180969&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #90 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180970&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #91 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180971&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #92 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- *** Bug 39203 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #93 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I think this is as far as this particular bug should go.. we should regroup for improving the 'Format'/'Local HTML Styling' tab for per notice styling options in follow-up bug 38090. What we introduce here is a clearer way of applying CSS styles globally to HTML Notices.. be that Email, Print or Both. What we do need to remember however, is that whilst this allows one to format HTML notices with much more options, many email clients will not fully respect your HTML emails.. HTML email generally only support an older subset of the HTML standard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39410 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #94 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- We should also consider the thoughts on bug 39410 here... I'm starting to doubt my approach.. whilst I feel this is clearer already, it also confuses end users given the restrictions placed on valid HTML inside an email. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #95 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Everything here is looking good but once I add some CSS to AllNoticeCSS t/db_dependent/Koha/Notice/Message.t fails. There is also a few complaints from the QA script about files needing to be tidy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Bug 35267 depends on bug 30287, which changed state. Bug 30287 Summary: Notices using HTML render differently in notices.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180963|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184037&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180964|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184038&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180965|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184039&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180966|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184040&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180967|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184041&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180968|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184042&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180969|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184043&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180970|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184044&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180971|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184045&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #105 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184046&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184037|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187746&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184038|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187747&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184039|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187748&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184040|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187749&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184041|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187750&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184042|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187751&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184043|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187752&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184044|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187753&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184045|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187754&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184046|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187755&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #116 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Just a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #117 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- patch doesnt currently apply. I will see if I cannot rebase as it only seems to be sysperf.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Open Fifth list of Sponsors| |<https://openfifth.co.uk> Status|Patch doesn't apply |Needs Signoff Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187749|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #118 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193209&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #119 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193210&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #120 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193211&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #121 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193212&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #122 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193213&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #123 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193214&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #124 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193215&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #125 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193216&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #126 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193217&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #127 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193218&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #128 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Just a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193214|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193216|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #129 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196188&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #130 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196189&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #131 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196190&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #132 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196191&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #133 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196192&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #134 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196193&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #135 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196194&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #136 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196195&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #137 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196196&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #138 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196197&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com --- Comment #139 from Marion Durand <marion.durand@biblibre.com> --- Just a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Felicie <felicie.thiery@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicie.thiery@biblibre.com --- Comment #140 from Felicie <felicie.thiery@biblibre.com> --- Hello, I have tested it, I encountered errors in the following step: ## UI 4) Under 'Tools > Notices and Slips', edit a notice and note we have a new accordion near the top of the page that displays the content of 'AllNoticeCSS', 'EmailNoticeCSS', 'PrintNoticeCSS' and 'PrintSlipCSS' preferences for the end users reference → The " PrintSlipCSS" is not displaying → There is a typo in the class name "organge" ## Testing the functionality 2) Confirm that the generated notice contains the correct classes and styles -> There are classes but not styles into the HTML file 3) Enable 'ManageNotices' preference from the dependency bug -> I don't find the syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196188|0 |1 is obsolete| | Attachment #196189|0 |1 is obsolete| | Attachment #196190|0 |1 is obsolete| | Attachment #196191|0 |1 is obsolete| | Attachment #196192|0 |1 is obsolete| | Attachment #196193|0 |1 is obsolete| | Attachment #196194|0 |1 is obsolete| | Attachment #196195|0 |1 is obsolete| | Attachment #196196|0 |1 is obsolete| | Attachment #196197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #141 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196229&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #142 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196230&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #143 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196231&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #144 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196232&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #145 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196233&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #146 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196234&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #147 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196235&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #148 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196236&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #149 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196237&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #150 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196238&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #151 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196239&action=edit Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output - Add missing PrintSlipCSS accordion panel to the notice editor - Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output - Include inline <style> blocks in print-notices.tt template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #152 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Updated Test Plan # Test plan ## Setup 1) Apply patches and run database updates 2) Verify that 'NoticeCSS' and 'SlipCSS' have been renamed to 'EmailNoticeStylesheet' and 'PrintSlipStylesheet' in Admin > System preferences > Tools > Notices and slips 3) Confirm that 'AllNoticeCSS', 'EmailNoticeCSS', 'PrintNoticeCSS' and 'PrintSlipCSS' are present in the same location ## UI — Accordion display 1) Go to Tools > Notices and Slips, edit any notice 2) Confirm a 'Global HTML Notice Styles' section is present near the top with four collapsible panels: - All Notice CSS - Email Notice CSS - Print Notice CSS - Print Slip CSS 3) Each empty panel should show "None defined" 4) If you have syspref admin rights, each panel should show an 'Edit' shortcut link ## Adding styles 1) Add to 'AllNoticeCSS': .alltest { color: red } 2) Add to 'EmailNoticeCSS': .emailtest { color: green } 3) Add to 'PrintNoticeCSS': .printtest { color: orange } 4) Confirm all four accordion panels now show their CSS content ## Notice template Edit the WELCOME notice HTML template to include: ```html <p> This is a notice for testing<br> <span class="alltest">All message transport types should display this red</span><br> <span class="emailtest">Only email notices should display this green</span><br> <span class="printtest">Only print notices should display this orange</span><br> All done </p> Queuing test notices (using patron 'Henry A') 1. Remove Henry's email address; queue a Welcome print notice via More > Send welcome 2. Add a primary email for Henry; queue a Welcome email notice via More > Send welcome 3. On Henry's Notices tab, click the print notice title — confirm red and orange text are shown, green is not 4. Click the email notice title — confirm red and green text are shown, orange is not gather_print_notices.pl — HTML output 1. Run: gather_print_notices.pl --output html 2. Open the generated HTML file 3. Confirm a block containing the AllNoticeCSS rules is present in the 4. Confirm a block containing the PrintNoticeCSS rules is present in the 5. Confirm the notice content renders with the correct colors (red for .alltest, orange for .printtest) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #153 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thankyou for all the testing.. I've updated the test plan a little, but it's mostly the same.. just removing some of the historical bits. I've also added a final patch to address your testing result.. seems we lost some bits over the years fo rebases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #154 from Emmanuel Bétemps <e.betemps@gmail.com> --- The 3rd and 4th steps "gather_print_notices.pl — HTML output" don't work -> we did not see any of the 2 blocks containing the AllNoticeCSS or PrintNoticeCSS rules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #155 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Have you got that last patch applied.. the one that fixes this? I just ran through the test plan again myself to check, I see the CSS blocks near the top of the generated file in the <head>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #156 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196279&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #157 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196280&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #158 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196281&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #159 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196282&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #160 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196283&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #161 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196284&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #162 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196285&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #163 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196286&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #164 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196287&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #165 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196288&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #166 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196289&action=edit Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output - Add missing PrintSlipCSS accordion panel to the notice editor - Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output - Include inline <style> blocks in print-notices.tt template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #167 from Marion Durand <marion.durand@biblibre.com> --- trivial rebase needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #168 from Marion Durand <marion.durand@biblibre.com> --- I'm testing now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196285|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #169 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196290&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #170 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196291&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #171 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196292&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #172 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196293&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #173 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196294&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #174 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196295&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #175 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196296&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #176 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196297&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #177 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196298&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #178 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196299&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #179 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 196300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196300&action=edit Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output - Add missing PrintSlipCSS accordion panel to the notice editor - Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output - Include inline <style> blocks in print-notices.tt template Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #180 from Marion Durand <marion.durand@biblibre.com> --- I just did a quick rebase and tested again. It worked perfectly. Thank you everyone ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com |domm@plix.at CC| |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #181 from Thomas Klausner <domm@plix.at> --- Created attachment 196365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196365&action=edit Bug 35267: (follow-up) Adapt atomicupdate to new DB schema and add a missing newline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #182 from Thomas Klausner <domm@plix.at> --- The QA script complains in three places, but I guess we can ignore these: There are pod_coverage errors for internal functions (i.e. starting with _, like C4/Letters.pm, _add_attachments And koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt is not tidy, but the tidier cannot tidy: Tidying file 1/1 (koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt) [error] ImOA_AyQEd.tt: SyntaxError: CssSyntaxError: Unknown word [ (1:1) [error] > 1 | [% all_notice_css | $raw %] [error] | ^ at misc/devel/tidy.pl line 108. So I will ignore these complaints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196293|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196295|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196296|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196297|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196298|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #183 from Thomas Klausner <domm@plix.at> --- Created attachment 196484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196484&action=edit Bug 35267: Add and Update Notice CSS system preferences This patch clarifies the system level notice css preferences. We rename NoticeCSS to EmailNoticeStylesheet We rename SlipCSS to PrintSlipStylesheet We add AllNoticeStylesheet We add AllNoticeCSS to contain inline CSS for all html notices We add EmailNoticeCSS to contain inline CSS for Email notices We add PrintNoticeCSS to contain inline CSS for Print notices We add PrintSlipCSS to contain inline CSS for Print slips Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #184 from Thomas Klausner <domm@plix.at> --- Created attachment 196485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196485&action=edit Bug 35267: Add preferences to UI Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #185 from Thomas Klausner <domm@plix.at> --- Created attachment 196486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196486&action=edit Bug 35267: Expose style preferences in template editor Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #186 from Thomas Klausner <domm@plix.at> --- Created attachment 196487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196487&action=edit Bug 35267: Apply preferences to preview and mailing This patch applies the new style preferences to the preview display and email sending code. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #187 from Thomas Klausner <domm@plix.at> --- Created attachment 196488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196488&action=edit Bug 35267: Move JS to bottom in printslip Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #188 from Thomas Klausner <domm@plix.at> --- Created attachment 196489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196489&action=edit Bug 35267: Migrate accounts_summary to printslip This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to circ/printslip as this is a slip rather than a notice. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #189 from Thomas Klausner <domm@plix.at> --- Created attachment 196490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196490&action=edit Bug 35267: Update unit tests This patch simply updates the existing unit tests to rename NoticeCSS to AllNoticesStylesheet as per the rest of the patchset. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #190 from Thomas Klausner <domm@plix.at> --- Created attachment 196491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196491&action=edit Bug 35267: (follow-up) Add explanatory note to CSS displays This patch adds a simple explanatory note to each of the Notice CSS display options in the notices template editor page Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #191 from Thomas Klausner <domm@plix.at> --- Created attachment 196492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196492&action=edit Bug 35267: (follow-up) Remove 'apply to all' from format With the introduction of more granular global preferences for notice CSS we no longer need the somewhat confusing per notice but apply to all format checkbox. As suggested by Lucas, this patch removes that option. This is safe to remove at this stage as the feature in question isn't really working given the second bug implimenting most of the functionality to expose it is still in the queue. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #192 from Thomas Klausner <domm@plix.at> --- Created attachment 196493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196493&action=edit Bug 35267: (follow-up) More comprehensive and db agnostic tests This patch updates our unit tests to be more agnostic to prior database state during testing by mocking more of the preferences. We also add more tests to ensure we fully cover the new preferences and their options. Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #193 from Thomas Klausner <domm@plix.at> --- Created attachment 196494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196494&action=edit Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output - Add missing PrintSlipCSS accordion panel to the notice editor - Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output - Include inline <style> blocks in print-notices.tt template Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #194 from Thomas Klausner <domm@plix.at> --- Created attachment 196495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196495&action=edit Bug 35267: (follow-up) Adapt atomicupdate to new DB schema and add a missing newline Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #195 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There is some stuff that is not tidy in print-notices.tt. I would just make a tidy commit and continue here. But when I do so: kohadev-koha@kohadevbox:koha(main)$ perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt Tidying file 1/1 (koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt) [error] wN54SkWCa9.tt: SyntaxError: CssSyntaxError: Unknown word [ (1:1) [error] > 1 | [% all_notice_css | $raw %] [error] | ^ at misc/devel/tidy.pl line 108. Some files cannot be tidied: * koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt [error] wN54SkWCa9.tt: SyntaxError: CssSyntaxError: Unknown word [ (1:1) [error] > 1 | [% all_notice_css | $raw %] [error] | ^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #196 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- The tidy script runs Prettier on the template, and Prettier's CSS parser chokes on: <style nonce="[% Koha.CSPNonce | $raw %]">[% all_notice_css | $raw %]</style> It tries to parse [% all_notice_css | $raw %] as CSS and fails with CssSyntaxError: Unknown word. This is a Template Toolkit variable being injected as raw CSS — Prettier fundamentally cannot parse this. The tidy tool itself confirms "Some files cannot be tidied" and exits with the same error. This is a false catch in the QA script in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #197 from Thomas Klausner <domm@plix.at> --- I agree that that's a false error reported by the tidyer, and have mentioned this in comment#182 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267#c182 before setting PassQA. So I think we can set the status again to PassQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #198 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197501&action=edit Bug 35267: (follow-up) Add POD coverage for private subroutines Add POD documentation for private subroutines in C4/Letters.pm and fix the POD heading for _type in Koha/Notice/Message.pm to satisfy the pod_coverage QA check. Also fixes a typo in the existing _add_attachments POD heading (_add_attachements → _add_attachments). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|roadmap_25_05 |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #199 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197692&action=edit Bug 35267: Ignore style tags with TT tags Patch from commit c5767f8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #200 from Jonathan Druart <jonathan.druart@gmail.com> --- Don't ignore tidy errors, it will break Jenkins ;) If something cannot be parsed by prettier you need to flag it with prettier-ignore to ignore. See previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #201 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #202 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes for this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #203 from Jonathan Druart <jonathan.druart@gmail.com> --- AllNoticeStylesheet is missing in sysprefs.sql NoticeCSS and SlipCSS has not been removed from sysprefs.sql EmailOverduesNoEmail is misplaced in sysprefs.sql please run prove t/db_dependent/check_sysprefs.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #204 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197768&action=edit Bug 35267: Fix check_sysprefs.t Patch from commit 5d0e98b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #205 from Jonathan Druart <jonathan.druart@gmail.com> --- Martin, please review the last patch before push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #206 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197817&action=edit Bug 35267: Fix check_sysprefs.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #207 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #208 from David Cook <dcook@prosentient.com.au> --- I need to pull down origin, but where is "Local HTML Notice Styles" supposed to go? It is appearing below "SMS" and "Print", but I imagine it should be up in its own fieldset below "Global HTML Notice Styles"? I note the hint is "These format settings apply when a notice is printed." Is that right? I'm not sure what "Local HTML Notice Styles" means, but right now it's in the HTML section rather than the CSS section? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 --- Comment #209 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #208)
I need to pull down origin, but where is "Local HTML Notice Styles" supposed to go? It is appearing below "SMS" and "Print", but I imagine it should be up in its own fieldset below "Global HTML Notice Styles"?
I note the hint is "These format settings apply when a notice is printed." Is that right? I'm not sure what "Local HTML Notice Styles" means, but right now it's in the HTML section rather than the CSS section?
I noticed yesterday that there are a lot of translations stemming from this bug with wrong capitalization - that means double translation work for a lot of us. Can we please fix? Local HTML Notice Styles is one of these. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42434 [Bug 42434] Capitalization: Print Slip CSS, Print Notice CSS... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #210 from Lisette Scheer <lisette@bywatersolutions.com> --- Was there a reason to move the CSS above the notices themselves? I think a lot of users will find that confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Clarify existing and add release notes| |new CSS options for Notice | |Templates. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #211 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42931 [Bug 42931] move Global HTML notice styles below the notices -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org