[Bug 13713] New: Remove useless constraint in Koha::Schema::Result::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Bug ID: 13713 Summary: Remove useless constraint in Koha::Schema::Result::Biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org 2 patches need to be moved from bug 11518. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35949&action=edit Bug 13713: WIP - Remove useless constraints previously added This patch removes the 3 constraints added by patch from bug 11518. Having 1-n + 1-1 relations for the same field is a non-sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added a follow-up for removing some unneeded code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35950&action=edit Bug 13713: Follow-up removing biblioitem routines There is no need to define biblioitem routines, if we can access them via biblioitemnumber. Note that we actually need a FK for biblio in the items table. Now we do need the intermediate level via biblioitems in the Items.t code. Even better, we should move biblioitem to biblio. Formally it is 1-n, but in reality it is 1-1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11518 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Bug 13713 depends on bug 11518, which changed state. Bug 11518 Summary: Add new method to Koha::Schema::Result::Item that will always return the correct itemtype http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35949|0 |1 is obsolete| | Attachment #35950|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36089&action=edit [PASSED QA] Bug 13713: Follow-up removing biblioitem routines There is no need to define biblioitem routines, if we can access them via biblioitemnumber. Note that we actually need a FK for biblio in the items table. Now we do need the intermediate level via biblioitems in the Items.t code. Even better, we should move biblioitem to biblio. Formally it is 1-n, but in reality it is 1-1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35949|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- First patch was missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13923 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org