[Bug 35372] New: Support for empty AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Bug ID: 35372 Summary: Support for empty AdvancedSearchTypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Some organisations using Koha do not have holdings/items, and would like to be able to hide the advanced search 'items' panels, controlled by the AdvancedSearchTypes system preference. However if this is left empty, item types filters still show by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Depends on| |12478, 33186 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 [Bug 33186] Use template wrapper for tabs on search history and advanced search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 159149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159149&action=edit Bug 35372: Add support for AdvancedSearchTypes to be empty and disabled This enhancement makes it possible to leave the AdvancedSearchTypes system preference empty if your library would like to disable the item filter tabs available on the staff interface advanced search. It also adds a message to the system preference description to describe this. To test: 1. Go to Koha Administration -> system preferences. Search for the AdvancedSearchTypes system preference and remove its contents, so it is saved empty. 2. Go to advanced search in the staff interface. Notice the item types tab still shows as a filter option. 3. Apply the patch, restart services and refresh the advanced search 4. Confirm the item types tab no longer shows. 5. Add something back to the AdvancedSearchTypes system preference i.e. itemtypes, ccode 6. Go back to advanced search and confirm your expected tabs show as normal Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- We should make the same change in the OPAC shouldn't we? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 159189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159189&action=edit Bug 35372: Add support for OpacAdvancedSearchTypes to be empty and disabled This enhancement makes it possible to leave the OpacAdvancedSearchTypes system preference empty if your library would like to disable the item filter tabs available on the OPAC advanced search. It also adds a message to the system preference description to describe this. To test: 1. Go to Koha Administration -> system preferences. Search for the OpacAdvancedSearchTypes system preference and remove its contents, so it is saved empty. 2. Go to advanced search in the OPAC. Notice the item types tab still shows as a filter option. 3. Apply the patch, restart services and refresh the advanced search 4. Confirm the item types tab no longer shows. 5. Add something back to the OpacAdvancedSearchTypes system preference i.e. itemtypes, ccode 6. Go back to advanced search and confirm your expected tabs show as normal Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159149|0 |1 is obsolete| | Attachment #159189|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159266&action=edit Bug 35372: Add support for AdvancedSearchTypes to be empty and disabled This enhancement makes it possible to leave the AdvancedSearchTypes system preference empty if your library would like to disable the item filter tabs available on the staff interface advanced search. It also adds a message to the system preference description to describe this. To test: 1. Go to Koha Administration -> system preferences. Search for the AdvancedSearchTypes system preference and remove its contents, so it is saved empty. 2. Go to advanced search in the staff interface. Notice the item types tab still shows as a filter option. 3. Apply the patch, restart services and refresh the advanced search 4. Confirm the item types tab no longer shows. 5. Add something back to the AdvancedSearchTypes system preference i.e. itemtypes, ccode 6. Go back to advanced search and confirm your expected tabs show as normal Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159267&action=edit Bug 35372: Add support for OpacAdvancedSearchTypes to be empty and disabled This enhancement makes it possible to leave the OpacAdvancedSearchTypes system preference empty if your library would like to disable the item filter tabs available on the OPAC advanced search. It also adds a message to the system preference description to describe this. To test: 1. Go to Koha Administration -> system preferences. Search for the OpacAdvancedSearchTypes system preference and remove its contents, so it is saved empty. 2. Go to advanced search in the OPAC. Notice the item types tab still shows as a filter option. 3. Apply the patch, restart services and refresh the advanced search 4. Confirm the item types tab no longer shows. 5. Add something back to the OpacAdvancedSearchTypes system preference i.e. itemtypes, ccode 6. Go back to advanced search and confirm your expected tabs show as normal Sponsored-by: Education Services Australia SCIS Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. Change in behaviour. Should we adjust pref's value for existing installs? 2. + [% IF advancedsearchesloop %] You are adding a new block, adjust the indentation. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org