[Bug 18550] New: Patron card creator: Print output does not respect layout units
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Bug ID: 18550 Summary: Patron card creator: Print output does not respect layout units Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18584 (introduces layout grid) - Create a card layout wir a text field, an image and barcode. Use points as layout unit - Activate layout grid - Create PDF output, save. - Change layout unit to mm. - Create PDF output, save. - Compare PDFs. Verify that the positions are unchanged. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |veron@veron.ch |u | Depends on| |18541 --- Comment #1 from Marc Véron <veron@veron.ch> --- Please test on top of Bug 18541 - Patron card creator: Add a grid to support layout design Sorry for wrong bug number in intitial comment. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 [Bug 18541] Patron card creator: Add a grid to support layout design -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63167&action=edit Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout wir a text field, an image and barcode. Use points as layout unit - Activate layout grid - Create PDF output, save. - Change layout unit to mm. - Create PDF output, save. - Compare PDFs. Verify that the positions are unchanged (still using points). - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) Note: Patch not yet ready to sign-off because of som e c/p, but tests are welcome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63167|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 63219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63219&action=edit Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63219|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63320&action=edit [SIGNED-OFF] Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #5 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #6 from Marc Véron <veron@veron.ch> --- Still applies on current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 66932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66932&action=edit Follow-up: Add POD descriptions to subs This patch simply adds POD descriptions to subs affected by first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 [Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #8 from Marc Véron <veron@veron.ch> --- Still applies on current master. Would be nice to have it in next release because current behaviour is really a malfunction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67670&action=edit Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67671&action=edit Bug 18550: [Follow-up] Add POD descriptions to subs This patch simply adds POD descriptions to subs affected by first patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Testing Patron Card from scratch is not very intuitive. The code changes dont look bad. I loose my barcode when I use this patch set, but I trust that the test results of Mark and Josef are based on better card templates etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Bug 18550 depends on bug 18541, which changed state. Bug 18541 Summary: Patron card creator: Add a grid to support layout design https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 18541 that is not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Derryn <derrynj@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22900 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org