https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158356&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. NOTE: Refinements still required -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36119 [Bug 36119] Bookings to collect needs a print option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161044|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165014&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. NOTE: Refinements still required -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased ready for testing. The page is very basic as it stands, with the idea that we'll iterate and add actions into it once they become apparent. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #8 from Esther Melander <esther.melander@bywatersolutions.com> --- My test plan: 1. Search the catalog and make several items bookable. 2. Schedule bookings for those items. Try to do a variety of bookings, such as multiple patrons for the same item, overlap dates, specific item, any item, different titles. 3. Navigate to circulation, click on bookings. 4. The date range displayed may need adjustment to display the table. Adjust if needed and see the table. The table defaults to only showing bookings to be collected for "today". In order to see the pending bookings coming up, the dates selected needed to be adjusted in order to display all the ones I had created for the next month. I would prefer to have the pending bookings display for the next week by default. I suppose larger consortia may need it to be daily. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165278&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165278|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165280&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #14 from Aude Charillon <aude.charillon@ptfs-europe.com> --- A library team we work with has been experimenting with this. They made the following comments: 1) If a booking has been issued, it stays on the list. This is not useful to the library team: they would prefer to see only those bookings still to be collected. 2) This report needs to filter by library. It is not useful to see bookings for all libraries; the team needs to see bookings for their own library. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165279|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170398&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170400&action=edit Bug 33736: Add filter for holding library This patch adds the option to filter the pending bookings to collect report by items current holding library and defaults to the users logged in library. We also add the 'Pickup library' column to the report output so staff know whether the item needs collecting for sending to another library or for their own. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37652 [Bug 37652] Add alert for upcoming bookings at checkin -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38119 [Bug 38119] Add a combined 'Items to pull' report -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170398|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172716&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170399|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172718&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172720&action=edit Bug 33736: Add item location and filter by library to bookings to collect report This patch adds a new 'Location' field to the bookings to collect report. We display with the current item location or an onloan status with the due date. We also add filtering for status != 'waiting' to the base query to rule out items marked as ready for collection already (however, we don't yet have a way of marking such a status so this won't have any effect yet). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37652 Depends on|37652 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37652 [Bug 37652] Add alert for upcoming bookings at checkin -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Status|Signed Off |Failed QA --- Comment #26 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Unfortunately I found some issues: - There's a link to the configure tables view even though there's no associated table config. - The patron column has no search input even though it IS marked as searchable in the column object. - This one is mainly a question on UX, if I leave an input empty in the filter component it appears to filter w/ the last value it had. No deal-breaker in any way, just something that I noticed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172808&action=edit Bug 33736: Don't search on start_date if no date filter is defined -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172823&action=edit Bug 33736: Don't allow sorting on Location We need some special handling to sort on Location as it's got both a custom renderer and relies on _strings so the ordering and search won't return expected results without some custom function building. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172718|0 |1 is obsolete| | --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172837&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172720|0 |1 is obsolete| | --- Comment #34 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172839&action=edit Bug 33736: Add item location and filter by library to bookings to collect report This patch adds a new 'Location' field to the bookings to collect report. We display with the current item location or an onloan status with the due date. We also add filtering for status != 'waiting' to the base query to rule out items marked as ready for collection already (however, we don't yet have a way of marking such a status so this won't have any effect yet). Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172765|0 |1 is obsolete| | --- Comment #36 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172841&action=edit Bug 33736: (follow-up) Remove top-level embed in bookings.yaml For reference, see: bug 30536. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172808|0 |1 is obsolete| | --- Comment #38 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172843&action=edit Bug 33736: Don't search on start_date if no date filter is defined Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172823|0 |1 is obsolete| | --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172845&action=edit Bug 33736: Don't allow sorting on Location We need some special handling to sort on Location as it's got both a custom renderer and relies on _strings so the ordering and search won't return expected results without some custom function building. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@gmail.com --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Joubu has asked not to push changes to table configuration settings while the datatables bugs are progressing. Will check with him before pushing. I'll use the time to ask for a few small follow-ups: 1) Capitalization Holds & Bookings > Holds and bookings I am pretty sure we have removed all the & in the past, I think to ease translations. 2) Translatability a) These won't be translatable: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt + "title": "Pickup library", Please check all "title": b) This won't be tranlatable as well: tt file = single underscore + return __("On loan, due: ") . $date(row.item.checked_out_date); 3) Internal server error [2024/10/24 15:35:27] [ERROR] GET /api/v1/bookings: unhandled exception (Koha::Exceptions::BadParameter)<<Exception 'Koha::Exceptions::BadParameter' thrown 'A bad parameter was given' with parameter => start_date>> MariaDB [koha_kohadev]> select * from bookings; +------------+-----------+-----------+---------+-------------------+---------------------+---------------------+---------------------+---------------------+--------+ | booking_id | patron_id | biblio_id | item_id | pickup_library_id | start_date | end_date | creation_date | modification_date | status | +------------+-----------+-----------+---------+-------------------+---------------------+---------------------+---------------------+---------------------+--------+ | 11 | 19 | 184 | 393 | CPL | 2024-10-24 22:00:00 | 2024-10-30 22:59:59 | 2024-10-24 15:32:11 | 2024-10-24 15:32:11 | new | +------------+-----------+-----------+---------+-------------------+---------------------+---------------------+---------------------+---------------------+--------+ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172836|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173291&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172838|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173293&action=edit Bug 33736: Add filter for holding library This patch adds the option to filter the pending bookings to collect report by items current holding library and defaults to the users logged in library. We also add the 'Pickup library' column to the report output so staff know whether the item needs collecting for sending to another library or for their own. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172840|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173295&action=edit Bug 33736: Bootstrap 5 update Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172842|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173297&action=edit Bug 33736: Ensure datatable filter row takes visible into account We clone the header row, and then iterate it assuming the iterator index lines up with the column definition index of the datatables settings. However, if a column is hidden, this is not the case. Said column will not appear in the header row that's cloned and as such your iterator will no longer line up with the column settings index number of the settings array. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172844|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173299&action=edit Bug 33736: Add column settings definition for bookings report Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173301&action=edit Bug 33736: (QA follow-up) Holds & Bookings > Holds and bookings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173303&action=edit Bug 33736: (follow-up) Rebase fix for changed api date handling -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 rachel.schlachter@mtangel.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachel.schlachter@mtangel.e | |du -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #56 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Yes to all of that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- Just looking at the code, with the other work related to the REST API and timezone, I don't think what you are doing with the date filters is correct. You should do what is done on the background job page ("filter by last hour"). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- commit 025ed2d09aadc229490c94c5c82234e6942dbcf9 Bug 33736: Ensure datatable filter row takes visible into account I am really concerned about this commit. On bug 33484 AND bug 36640 I am adjusting this code to fix problems with the column visibility. I made sure that we didn't have conflict with the state, the column visibility, the hidden column (forced in the config), and the different tables. This patch should really be on its own bug and the different tables tested, not only this one. I am going to drop the changes made here for the other 2 bugs, but if we have 4 different codes (pre 33736, post 33736, 33736+33484, post 33736+33484+36640) to maintain in main and stable, it will be a nightmare to fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- The "Pickup library" column filter should be a dropdown list with the list of libraries (see patron search, item list on bib detail, etc.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like this is too much of a new feature for backport. There might also be some hidden dependencies on other new code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The enhancement adds a new release notes| |'Bookings to collect' | |report into the Circulation | |module. It parallels the | |'Holds to pull' report | |allowing staff to easily | |report against upcoming | |bookings and collect them | |from the shelves ready for | |collection by the patron | |who has the item booked. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #68 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Is there actually any 'addition_work_needed' here still.. I can't spot any so can we remove the keyword? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #70 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Sorry, what I mean is, I think there's no additional work needed anymore. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #71)

Comments 61, 63, 64?

Martin and Paul, can you please review and split into new bugs were needed? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Bug 33736 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 [Bug 40949] Bookings to collect shouldn't tell staff to check in items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #75 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.