[Bug 14541] New: Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Bug ID: 14541 Summary: Tax rate should not be forced to an arbitrary precision Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The following is an example gstrate for a real library 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625 Note the .08625 and .0863 Both of those rates show up as 8.6% for the order line editor ( acqui/neworderempty.pl ). There is no reason to force these numbers to be rounded and in fact makes the label not match the value! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41031&action=edit Bug 14541 - Tax rate should not be forced to an arbitrary precision The following is an example gstrate for a real library 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625 Note the .08625 and .0863 Both of those rates show up as 8.6% for the order line editor ( acqui/neworderempty.pl ). There is no reason to force these numbers to be rounded and in fact makes the label not match the value! Test Plan: 1) Set you gstrate pref to 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625 2) Edit an order line 3) Note that the tax rate pulldown lists 8.6% twice 4) Apply this patch 5) Refesh the page 6) Note the pulldown now lists the actual tax rate values -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Upping severity as this deals with money. It's possible for a librarian to accidentally select the wrong tax rate due to this bug! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14543 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Patch applied cleanly and works as expected, signing off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41031|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 41075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41075&action=edit Bug 14541 - Tax rate should not be forced to an arbitrary precision Work without error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, The tax rate is displayed at several places, at least acqui/supplier.tt. The change should affect all the places where it is displayed. You should also have a look at how I display them on bug 13323 using a template plugin: [% order.gstrate * 100 | $Price %] I can provide a patch on top of bug 13323 if you can wait for it to be pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10253 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, is the Price plugin the right one there? Because it's not an amount but a percentage value? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)
Hm, is the Price plugin the right one there? Because it's not an amount but a percentage value?
I'd say yes, we could add an option to the plugin later (something like "display as %"). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For me Price feels not right - and only 2 decimals I think? not enough for the percentage? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8)
For me Price feels not right - and only 2 decimals I think? not enough for the percentage?
It's better than 1, and the patch suggested to set it to 2, what the plugin does. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, but is 2 enough? Int wouldn't be for Kyle's example. Maybe we should just display 'as it is configured' and not cut it off. .07625 would be 7.625 I think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #11 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Kyle, The tax rate is displayed at several places, at least acqui/supplier.tt. The change should affect all the places where it is displayed. You should also have a look at how I display them on bug 13323 using a template plugin: [% order.gstrate * 100 | $Price %]
I can provide a patch on top of bug 13323 if you can wait for it to be pushed.
That works for me Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13323 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org