[Bug 13380] New: Auto fill order cancellation reasons from authorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Bug ID: 13380 Summary: Auto fill order cancellation reasons from authorised values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |7162 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13369 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34090&action=edit Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34091&action=edit Bug 13380: Add the AV in the install files (This will completely done when the patch will be QAed) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34090|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34140&action=edit Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13379 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about enforcing an authorized value here - maybe we treat it similar to the bsort authorized values? The statistic fields are normal inputs until you add values for the authorized value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
I am not sure about enforcing an authorized value here - maybe we treat it similar to the bsort authorized values? The statistic fields are normal inputs until you add values for the authorized value.
Yes maybe, we could. But how to deal with existing values? I worked on the assumption that there won't be many and many reasons. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure, but I think as we introduced it as a free text field people might have left unstructured comments and could end up with quite a long list for the authorized value - which might also not very welcome. Maybe put the SQL for the update on the wiki and leave as is? I would make the value show up in the list of authorized values but leave it empty I think. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
I am not sure, but I think as we introduced it as a free text field people might have left unstructured comments and could end up with quite a long list for the authorized value - which might also not very welcome.
I am not sure a lot of people already used it, it has only been pushed in 3.18. 200 characters is quite long for an order cancellation reason :)
Maybe put the SQL for the update on the wiki and leave as is? I would make the value show up in the list of authorized values but leave it empty I think.
I don't understand what you meant here, sorry :-/ What about a warning on updating the DB : "the field XXX for order YYY with value ZZZ has been truncated"? Or we could extend authorised_values.lib to a TEXT? But I don't like this solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the question is if this is going to be in 3.18.x or as a new enhancement in 3.20. And by then... libraries will have used it. I think currently as a input field it invites for longer unstructured comments. What I meant is that I would not transform the existing reasons into an authorized value for existing installations but leave things as they are and have the auth_value as a non-enforced option. That would also avoid the truncation problem. Maybe we should ask for opinions on the list? Some good feedback there recently. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|enhancement |normal --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Katrin Fischer from comment #8)
I think the question is if this is going to be in 3.18.x or as a new enhancement in 3.20. And by then... libraries will have used it. I think currently as a input field it invites for longer unstructured comments.
What I meant is that I would not transform the existing reasons into an authorized value for existing installations but leave things as they are and have the auth_value as a non-enforced option. That would also avoid the truncation problem.
Maybe we should ask for opinions on the list? Some good feedback there recently.
I'm happy to classify this as a bugfix and push it for 3.18.3 there shouldn't have been too much usage of it by then. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34091|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34746&action=edit Bug 13380: Add the AV in the install files (This will completely done when the patch will be QAed) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34140|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34747&action=edit Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- QA Issue: The new authorized values need to be added to each translation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #12)
QA Issue: The new authorized values need to be added to each translation.
Kyle, As you know, this change is very boring to do. I would prefer to wait for the QA step passes and the wording is validated before to add the changes to all languages. I hope it makes sense for you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you give Jonathan feedback on the wording? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34746|0 |1 is obsolete| | Attachment #34747|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35695&action=edit [PASSED QA] Bug 13380: Add the AV in the install files (This will completely done when the patch will be QAed) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35696&action=edit [PASSED QA] Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
(In reply to Kyle M Hall from comment #12)
QA Issue: The new authorized values need to be added to each translation.
Kyle, As you know, this change is very boring to do. I would prefer to wait for the QA step passes and the wording is validated before to add the changes to all languages. I hope it makes sense for you.
In that case, I would suggest No reason => No reason provided Sold out => Out of stock Restocking => Already ordered Does that make sense? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wondering, what is meant here? Restocking => Already ordered -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #18)
Wondering, what is meant here? Restocking => Already ordered
Yes I am not sure it's what I meant. Restocking means the supplier does not have the item and you want to cancel it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35767&action=edit Bug 13380: Wording changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35768&action=edit Bug 13380: Add ORDER_CANCELLATION_REASON AV to all language files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could just leave it out and go with 2 status? Restocking and out of stock seem very similar. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, I think there is a little typo: ('ORDER_CANCELLATION_REASON', 1, 'Old of stock'), it's in a/installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35767|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35773&action=edit Bug 13380: Wording changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Bug 13380 depends on bug 7162, which changed state. Bug 7162 Summary: Factorize code for order cancellation and add field for giving a reason http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The plan was to have this in the maintenance releases (see comment #9) - Tomas, could you please push soon? Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry to say this, but we missed a dependency :( Bug 13379 - changes the category to varchar(16). This means that on updating to 3.18.05 the value is too short and the code ends up being ORDER_CANCELLATI -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am afraid we need a follow up patch with another database update: - changing the size of the 2 colums like in patch 13379 - changing the shortened codes the correct full length codes Not sure if there is a better solution, but I don't see one right now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In the GUI the problem manifests as follows: - the cancellation reason input field shows "0" - an entered cancellation reason (free text) saves correctly to the database - the entered reason is not shown on the cancelled order line So basically we are back to as before, with the change that the display is affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37144&action=edit Bug 13380: 3.18.x Fix previous DB entry The DB entry from bug 13379 should have been executed before bug 13380. The AV category now contain truncated values. This patch restores the correct category values. The DB entry from bug 13379 should have been pushed before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 37144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37144 Bug 13380: 3.18.x Fix previous DB entry Review of attachment 37144: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13380&attachment=37144) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +9733,5 @@
+# IMPORTANT +# Here should be DB entry from 13379 + +$DBversion = "3.18.05.001";
Should be 002 of course. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37163&action=edit [master] Bug 13380: Follow-up - only run database update, when it hasn't been run already As the ORDER_CANCELLATION_REASON authorised value has been backported to 3.18.5, we need to make sure that the database update is only run once. This patch adds a check for the existance of the authorised value in order to decide if the databaes update can be run. To test: - Create a branch 3.19.00.016 - Make sure you have a few orders where the cancellationreason is set (cancel an order, enter a reason) - Update your branch to master + this patch - Run the web installer - ORDER_CANCELLATION_REASON authorised value category is created - Reset your system preference Version to 3.19.00.015 - Run database update again - no changes are made, all is fine Or: - Create a branch 3.18.04 with cancelled orders - Update to latest 3.18.x - Make sure ORDER_CANCELLATION_REASON has been created - Dump database - Switch to master without this patch - Run update - verify more O_C_R were created (bad) - Load database - Update to master with this patch - All should be fine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37163|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37179&action=edit [master] Bug 13380: Follow-up - only run database update, when it hasn't been run already Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35695|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Obsoleted the already pushed patches - the last one for master needs QA now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37179|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37363&action=edit [PASSED QA] Bug 13380: Follow-up - only run database update, when it hasn't been run already As the ORDER_CANCELLATION_REASON authorised value has been backported to 3.18.5, we need to make sure that the database update is only run once. This patch adds a check for the existance of the authorised value in order to decide if the databaes update can be run. To test: - Create a branch 3.19.00.016 - Make sure you have a few orders where the cancellationreason is set (cancel an order, enter a reason) - Update your branch to master + this patch - Run the web installer - ORDER_CANCELLATION_REASON authorised value category is created - Reset your system preference Version to 3.19.00.015 - Run database update again - no changes are made, all is fine Or: - Create a branch 3.18.04 with cancelled orders - Update to latest 3.18.x - Make sure ORDER_CANCELLATION_REASON has been created - Dump database - Switch to master without this patch - Run update - verify more O_C_R were created (bad) - Load database - Update to master with this patch - All should be fine Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Followup pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org