[Bug 7075] New: Fine in days values are returned for patrons with past overdues when fine in days is set to 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Bug #: 7075 Summary: Fine in days values are returned for patrons with past overdues when fine in days is set to 0 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com When Members.pm checks to see whether a particular patron can check out, it checks for issuingrules.finedays "WHERE finedays IS NOT NULL." If the user has created a rule via Circulation and fines rules, finedays will always be 0 even if an empty value has been submitted. This causes Members::IsMemberBlocked to return a value when it should not. [09:57] <sekjal> IsMemberBlocked checks for finedays IS NOT NULL [09:58] <oleonard> ...and it's 0. [09:58] <sekjal> so, if you have finedays = 0 in any of your rules, it'll trigger [09:59] <sekjal> so, in that case, it'll just take the date difference between the returndate, and the current date [09:59] <sekjal> which means it would grow to 44 tomorrow [09:59] <sekjal> and so on [09:59] <sekjal> that's.... bad [09:59] <libsysguy> ^^ [09:59] <oleonard> And you can't set finedays to null when editing an issuing rule [10:00] <libsysguy> so we could change that check or null or 0 [10:00] <libsysguy> and it would fix your issue right [10:00] <sekjal> yes, that's the fix [10:00] <sekjal> one more line to the SQL [10:00] <sekjal> "AND finedays != 0" http://stats.workbuffer.org/irclog/koha/2011-10-21#i_795577 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |oleonard@myacpl.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-10-21 14:28:08 UTC --- Created attachment 6016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6016 Proposed fix Changes "WHERE finedays IS NOT NULL" to "WHERE finedays > 0" in order to accomodate 0 values in issuingrules.finedays. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |trivial --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-10-21 16:11:07 UTC --- Looks like the trigger for the manifestation of this bug (blocked checkout when fine in days is not set) is only caused by a returndate in old_issues set some time in the future. In this case it was a result of manual data manipulation for the purpose of testing, so it seems unlikely to happen in the normal course of operation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 22:03:34 UTC --- I think safer, to do WHERE finedays IS NOT NULL AND finedays > 0 Sometimes null behaves weirdly in some database engines. Have submitted a different patch doing that -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 22:03:42 UTC --- Created attachment 6169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6169 Bug 7075 : Alternative patch to solve the finedays = 0 issue -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6016|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-18 08:03:49 UTC --- I tried to reproduce the problem: - set circulation rules and made sure finedays was 0 in the database - checked out an item, returned it - set the returndate in old_issues to a date in the future What did I miss? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 08:44:58 UTC --- Setting status to "in discussion", if no one is able to reproduce the problem now, should be closed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Chris / Owen = can you still reproduce the problem (seems katrin can't) ? If no, i'll RESO/INVALID this bug -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- This bug was made moot by the patch for bug 6328. Setting to RESO/INVALID. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org