[Bug 21983] New: Deleting a bib does not delete a request's link to it - missing foreign key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Bug ID: 21983 Summary: Deleting a bib does not delete a request's link to it - missing foreign key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com illrequests.biblio_id should be a foreign key to biblio.biblionumber, but it's not! When a biblio is deleted, illrequests.biblio_id should be null-ed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 83226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83226&action=edit Bug 21983: Add foreign key constraint on biblio_id This patch adds a foreign key constraint on biblio_id, this means that, amongst other things, if a bib is deleted that an ILL request is a attached to, the ILL request is no longer attached to that bib. Test plan: - Apply the patch - Create an ILL request, a bib should automatically be created for the item being requested - Note that when viewing the request, a link to the bib is displayed in the ILL request list view - Delete the bib - Refresh the ILL request list view - TEST => Note that the link to the bib no longer exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83226|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 83227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83227&action=edit Bug 21983: Add foreign key constraint on biblio_id This patch adds a foreign key constraint on biblio_id, this means that, amongst other things, if a bib is deleted that an ILL request is a attached to, the ILL request is no longer attached to that bib. Test plan: - Apply the patch - Create an ILL request, a bib should automatically be created for the item being requested - Note that when viewing the request, a link to the bib is displayed in the ILL request list view - Delete the bib - Refresh the ILL request list view - TEST => Note that the link to the bib no longer exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23@gmail.com --- Comment #3 from Michal Denar <black23@gmail.com> --- Please rebase on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about this one, as we have deleted_biblio that is often useful for reporting. I imagine some libraries will want to remove ILL records from the catalog once the request is finished, but might still want to have the bibliographic information for reporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #4)
I am not sure about this one, as we have deleted_biblio that is often useful for reporting. I imagine some libraries will want to remove ILL records from the catalog once the request is finished, but might still want to have the bibliographic information for reporting.
I can confirm that this is indeed very true, yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- But it's just a foreign key to the (now deleted) bib ID, is that useful information that needs preserving? Sorry, genuine question, I'm not being facetious :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Isherwood from comment #6)
But it's just a foreign key to the (now deleted) bib ID, is that useful information that needs preserving? Sorry, genuine question, I'm not being facetious :)
As long as the bilbio_id is there, you can join on the deleted* tables and get information about the records that were requested. This is interesting information to libraries. Example: if a record was requested multiple times, they might to purchase it. If records from a certain subject are ordered more than other subjects, they might want to shift the budget in this direction, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Martin solved this somewhere else by having a separate column for the deleted ID as this will allow to have cleaner FK constraints, but I don't quite remember the bug report at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still think we want to preserve the biblionumber, I am open to ideas on the best way of doing it. It probably is more useful for backends that import a full MARC record from another ILL, as this will have more information than the request itself. But for all backends the biblionumber als provides a way to find the item linked to it... and then you can look up in statistics, issues, old_issues etc. So even if you have a 'slim' record, it's something we'd like to keep. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33873 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Should we add a deleted_biblio_id attribute? or column? I'd say an attribute. We have the same problem with borrowernumber, but worse, with a DELETE. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- as biblio_id is in the illrequests I think it would make things easier to have the deleted one there as well. Same for borrowernumber, it makes report writing much easier than a subquery to illrequestattributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=Bug, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32630 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #11)
as biblio_id is in the illrequests I think it would make things easier to have the deleted one there as well. Same for borrowernumber, it makes report writing much easier than a subquery to illrequestattributes.
There is also: Bug 32630 - Don't delete ILL requests when patron is deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=Bug | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm working on this. The plan: - Add illrequests.deleted_biblio_id - Make the db_rev move the biblio_id to deleted_biblio_id where needed - Make Koha::Biblio->delete deal with that change as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83227|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting a bib does not |Better handling of deleted |delete a request's link to |biblios on ILL requests |it - missing foreign key | CC| |jonathan.druart+koha@gmail. | |com, | |kyle@bywatersolutions.com, | |nick@bywatersolutions.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152005&action=edit Bug 21983: DB update This patch: - Adds a illrequests.deleted_biblio_id column - Adjusts existing db_rev so people upgrading have the biblio_id value moved to the also created column, before attempting to add the FK constraint on the biblios table. - Adds a new db_rev for those who unfortunately already updated, it should be idempotent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152006&action=edit Bug 21983: DBIC schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152007&action=edit Bug 21983: Add Koha::Biblio->ill_requests This patch adds a new method, used for retrieving the linked ill requests for a biblio. To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152008&action=edit Bug 21983: Make DelBiblio update linked ILL requests This patch makes DelBiblio update the biblio linked ILL requests so the value in biblio_id is moved to the deleted_biblio_id. The change is covered by tests. To test: 1. Apply this patchset 2. Run: $ ktd --shell k$ updatedatabase k$ qa --run-tests => SUCCESS: Tests pass! All green/good 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152005|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152010&action=edit Bug 21983: DB update This patch: - Adds a illrequests.deleted_biblio_id column - Adjusts existing db_rev so people upgrading have the biblio_id value moved to the also created column, before attempting to add the FK constraint on the biblios table. - Adds a new db_rev for those who unfortunately already updated, it should be idempotent. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152006|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152011&action=edit Bug 21983: DBIC schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152007|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152012&action=edit Bug 21983: Add Koha::Biblio->ill_requests This patch adds a new method, used for retrieving the linked ill requests for a biblio. To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152008|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152013&action=edit Bug 21983: Make DelBiblio update linked ILL requests This patch makes DelBiblio update the biblio linked ILL requests so the value in biblio_id is moved to the deleted_biblio_id. The change is covered by tests. To test: 1. Apply this patchset 2. Run: $ ktd --shell k$ updatedatabase k$ qa --run-tests => SUCCESS: Tests pass! All green/good 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Makes sense to me and keeps the data in a clean form whilst allowing us foreign keys. We could perhaps make deleted_biblio_id a foreign key on the deletedbiblios table too.. Signing off and leaving Katrin to QA and comment on the above question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll try to get to this ASAP, but might not make it today. If someone can take over, please do! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152010|0 |1 is obsolete| | Attachment #152011|0 |1 is obsolete| | Attachment #152012|0 |1 is obsolete| | Attachment #152013|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152056&action=edit Bug 21983: DB update This patch: - Adds a illrequests.deleted_biblio_id column - Adjusts existing db_rev so people upgrading have the biblio_id value moved to the also created column, before attempting to add the FK constraint on the biblios table. - Adds a new db_rev for those who unfortunately already updated, it should be idempotent. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152056|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152057&action=edit Bug 21983: DB update This patch: - Adds a illrequests.deleted_biblio_id column - Adjusts existing db_rev so people upgrading have the biblio_id value moved to the also created column, before attempting to add the FK constraint on the biblios table. - Adds a new db_rev for those who unfortunately already updated, it should be idempotent. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152058&action=edit Bug 21983: DBIC schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152059&action=edit Bug 21983: Add Koha::Biblio->ill_requests This patch adds a new method, used for retrieving the linked ill requests for a biblio. To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152060&action=edit Bug 21983: Make DelBiblio update linked ILL requests This patch makes DelBiblio update the biblio linked ILL requests so the value in biblio_id is moved to the deleted_biblio_id. The change is covered by tests. To test: 1. Apply this patchset 2. Run: $ ktd --shell k$ updatedatabase k$ qa --run-tests => SUCCESS: Tests pass! All green/good 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152063&action=edit Bug 21983: (QA follow-up) Skip deleted_biblio_id from the API object Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00, 23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00, 23.05.01 |23.11.00,22.11.07, 23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 sandeepj <sandeepjadhav@acharyamarathecollege.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandeepjadhav@acharyamarath | |ecollege.in Version|master |23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 [Bug 34276] upgrading 23.05 to 23.05.002 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Alex Mwithi <myalextech@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |myalextech@gmail.com --- Comment #32 from Alex Mwithi <myalextech@gmail.com> --- How do i solve this error Update errors : Upgrade to 23.05.00.002 [08:24:59]: Bug 21983 - Deleted biblio handling on ILL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Alex Mwithi from comment #32)
How do i solve this error
Update errors :
Upgrade to 23.05.00.002 [08:24:59]: Bug 21983 - Deleted biblio handling on ILL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741
Alex, which version are you upgrading from? See bug 34276. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #34 from Alex Mwithi <myalextech@gmail.com> --- (In reply to Pedro Amorim from comment #33)
(In reply to Alex Mwithi from comment #32)
How do i solve this error
Update errors :
Upgrade to 23.05.00.002 [08:24:59]: Bug 21983 - Deleted biblio handling on ILL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741
Alex, which version are you upgrading from? See bug 34276.
i'm upgrading from Koha 22.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This is very weird. Did a new test: 1) git checkout v22.11.07 2) reset_all 3) git checkout v23.05.01 4) updatedatabase Everything ran smoothly (including this bug 21983 DB update). I'm unable to reproduce this duplicate key error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Jeremiah <jhenderson@nsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhenderson@nsd.org --- Comment #36 from Jeremiah <jhenderson@nsd.org> --- Hello, I am experiencing the same issue as Alex "Upgrade to 23.05.00.002 [23:52:55]: Bug 21983 - Deleted biblio handling on ILL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741" Upgrading from 22.05 to 23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The history of illrequests_bibfk chaotic, I didn't find how this situation could happen but regarding the different reports we should add a separate check for the key (one for the FK, one for the key). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 sandeepj <sandeepjadhav@acharyamarathecollege.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152057|1 |0 is patch| | Attachment #152057|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 José Anjos <joseanjos@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseanjos@gmail.com --- Comment #38 from José Anjos <joseanjos@gmail.com> --- I have the same problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #39 from José Anjos <joseanjos@gmail.com> --- I had to delete Relation illrequests_ibfk_1 to be able to delete Index illrequests_bibfk Than, continue setup and the Relation and the Index was recreated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00,22.11.07, 23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 tony-the-hawk <antonio.falco@unito.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antonio.falco@unito.it --- Comment #40 from tony-the-hawk <antonio.falco@unito.it> --- I have same problem Upgrade to 23.05.00.002 [14:53:05]: Bug 21983 - Deleted biblio handling on ILL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741 but I can't find illrequests_bibfk in any table of my database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #41 from José Anjos <joseanjos@gmail.com> --- (In reply to tony-the-hawk from comment #40)
I have same problem
Upgrade to 23.05.00.002 [14:53:05]: Bug 21983 - Deleted biblio handling on ILL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741
but I can't find illrequests_bibfk in any table of my database.
Table: illrequests Relations: illrequests_ibfk_1 Index: illrequests_bibfk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #42 from Fridolin Somers <fridolin.somers@biblibre.com> --- Look at Bug 34276 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate, | |rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org