[Bug 27817] New: Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Bug ID: 27817 Summary: Enhance display of 245 fields throughout Acquisitions Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org There are multiple places in Acquisitions where only the 245a field from the title displays. It would be helpful to add additional subfields for subtitle (245b), part number (245n) and part name (245p) Being able to view the entire title would make receiving easier, more accurate and more efficient. The pages that would benefit from showing this info are as follows: ordered.pl invoice.pl basket.pl parcel.pl orderreceive.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20532 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118969&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 20532 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #3 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a "Template process failed" error. For all other pages I'm not seeing the additional info from the 245$b, 245$h, 245$n or 245$p subfields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Thanks for testing, Barbara. Please feel free to mark something "Failed QA" if anything doesn't work. It's not a setting which is reserved for the QA team. Because this was still "needs signoff" I didn't realize there was a problem with it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118969|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126323&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I couldn't (In reply to Barbara Johnson from comment #3)
I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a "Template process failed" error.
I couldn't reproduce this error, but the patch needed to be rebased so a new version is attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #7 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Here's what I have found so far in my testing: On basket.pl the title and subtitle display correctly in the 245|a and 245|b. However, it is also incorrectly including series data from the 490|a and 490|v. See the attachment acq_basket.png. The info highlighted in yellow is coming from the 490 tag. On ordered.pl only data from the 245|a is displaying. See the attachment acq_ordered.png. Each title that has been highlighted has a subtitle in the 245|b but it is not displaying. On orderreceive.pl, parcel.pl and invoice.pl the 245|a and 245|b display correctly. Actually parcel.pl is the the place the extra info from the 245|b would be most useful. I attached a screenshot (which_wimpy_kid_is_it.png) showing the display a staff person sees when receiving. In the example all four books are different wimpy kid titles, but without the subtitle displayed it's not readily apparent which is the correct book to receive. Staff then has to start looking at the ISBNS which is more time consuming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #8 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 130899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130899&action=edit acq_basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #9 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 130900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130900&action=edit acq_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #10 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 130901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130901&action=edit wimpy kid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you have a look at Barbara's comments please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Barbara Johnson from comment #7)
On basket.pl ... is also incorrectly including series data from the 490|a and 490|v.
basket.pl and invoice.pl have code to deliberately add the series information to the title variable: if ( $line{'title'} ) { my $volume = $order->{'volume'}; my $seriestitle = $order->{'seriestitle'}; $line{'title'} .= " / $seriestitle" if $seriestitle; $line{'title'} .= " / $volume" if $volume; } parcel.pl appears to be showing 245$b correctly for me in the "Already received" table, which is the only place this patch changes anything. The display of title information in the "Pending orders" table is not affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126323|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 139517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139517&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhance display of 245 |Enhance display of title |fields throughout |informatoin throughout |Acquisitions |acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhance display of title |Enhance display of title |informatoin throughout |information throughout |acquisitions |acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #12)
(In reply to Barbara Johnson from comment #7)
On basket.pl ... is also incorrectly including series data from the 490|a and 490|v.
basket.pl and invoice.pl have code to deliberately add the series information to the title variable:
if ( $line{'title'} ) { my $volume = $order->{'volume'}; my $seriestitle = $order->{'seriestitle'}; $line{'title'} .= " / $seriestitle" if $seriestitle; $line{'title'} .= " / $volume" if $volume; }
parcel.pl appears to be showing 245$b correctly for me in the "Already received" table, which is the only place this patch changes anything. The display of title information in the "Pending orders" table is not affected.
Maybe we could move the series information display to a separate bug. I can see that the code doesn't affect it - neither adding nor removing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31433 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31434 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139517|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139564&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I filed bug 31433 (order from existing) and bug 31434 (order receive) to complete the work here. This is already a huge improvement and important to libraries dealing with a lot of multi-part records and series that can only be differentiated by part number or part name. @Barbara: if you wanted to give this another try we could count my sign-off towards QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #17 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- In my latest test, I can confirm that I am able to view the 245abhnp on basket.pl, orderreceive.pl and invoice.pl. Only the 245a info is displayed on parcel.pl and I believe bug 31434 is supposed to address that. Also, only the 245a is displayed on ordered.pl - it would be helpful to see the additional info here as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Barbara. Do you want to sign-off with the sandboxes? Otherwise I can try to add your sign-off line later. (In reply to Barbara Johnson from comment #17)
In my latest test, I can confirm that I am able to view the 245abhnp on basket.pl, orderreceive.pl and invoice.pl.
Only the 245a info is displayed on parcel.pl and I believe bug 31434 is supposed to address that.
It does show, but only after you received something for the received oders, in the second table below the first. Bug 31434 is for the 'unreceiveds' table.
Also, only the 245a is displayed on ordered.pl - it would be helpful to see the additional info here as well.
Could you file that as a separate one? We'd probably want it for the spent too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139564|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 139679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139679&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #20 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I've signed off on this bug - this functionality will be so helpful. Also, I filed bug 31443 (for viewing titles from ordered.pl) and bug 31444 (for viewing titles on spent.pl) to complete the work already done here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139679|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140734&action=edit Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Ashley Johnson <ajohnson@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajohnson@jcls.org --- Comment #23 from Ashley Johnson <ajohnson@jcls.org> --- Excellent! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds remainder of release notes| |title/subtitle, medium, | |part name, and part number | |to several pages in the | |acquisitions module. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org