[Bug 12105] New: Remove duplicated plugin jquery.dataTables.columnFilter.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Bug ID: 12105 Summary: Remove duplicated plugin jquery.dataTables.columnFilter.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are copies of the DataTables plugin jquery.dataTables.columnFilter.js in both intranet-tmpl/lib/jquery/plugins and intranet-tmpl/prog/en/lib/jquery/plugins. The only one we should have is the one outside translated templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27277&action=edit Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- $ grep jquery.dataTables.columnFilter.js `find .` | cut -f1 -d':' Binary file ./.git/index matches ./koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.columnFilter.js ./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt ./koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.columnFilter.js ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/acqui/parcel.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/tools/manage-marc-import.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/catalogue/detail.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/lib/jquery/plugins/jquery.dataTables.columnFilter.js The fr-FR template files will be regenerated from en template files, so they can be ignored. There are two copies of the same file, and yes the non-language version should be used. ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt uses the [% interface %] version, which is the correct one. ./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt loads the javascript file, but does not use it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- One question. Is Order Line supposed to sort string-based and not numerically? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27277|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27379&action=edit [SIGNED OFF] Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I believe the sort order of the Order Line column is strange, but unrelated to this patch. The search area functions (filtering, paging, page size, etc.) worked fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27379|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27426&action=edit Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I believe the sort order of the Order Line column is strange, but unrelated to this patch. The search area functions (filtering, paging, page size, etc.) worked fine. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org