[Bug 36303] New: Add after_circ_action hook action for checking in item that was not checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 Bug ID: 36303 Summary: Add after_circ_action hook action for checking in item that was not checked out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org This patch adds an after_circ_action hook action for the case when an item that is not checked out is checked in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 163097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163097&action=edit Bug 36303: Add after_circ_action hook action for checking in item that was not checked out To test: 1) Run tests in t/db_dependent/Koha/Plugins/Circulation_hooks.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 Olivier Hubert <olivier.hubert@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olivier.hubert@inlibro.com --- Comment #2 from Olivier Hubert <olivier.hubert@inlibro.com> --- The fourth test fails on the current main branch: # Subtest: after_circ_action() hook tests 1..3 # Subtest: AddIssue 1..2 not ok 1 - AddIssue calls the after_circ_action hook # Failed test 'AddIssue calls the after_circ_action hook' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 80. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: checkout, ref: Koha::Checkout type: issue' # expected to find warning: (?^u:after_circ_action called with action: checkout, ref: Koha::Checkout type: issue) not ok 2 - AddIssue calls the after_circ_action hook (onsite_checkout case) # Failed test 'AddIssue calls the after_circ_action hook (onsite_checkout case)' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 84. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: checkout, ref: Koha::Checkout type: onsite_checkout' # expected to find warning: (?^u:after_circ_action called with action: checkout, ref: Koha::Checkout type: onsite_checkout) # Looks like you failed 2 tests of 2. not ok 1 - AddIssue # Failed test 'AddIssue' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 86. # Subtest: AddRenewal 1..1 not ok 1 - AddRenewal calls the after_circ_action hook # Failed test 'AddRenewal calls the after_circ_action hook' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 100. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: renewal, ref: Koha::Checkout' # expected to find warning: (?^u:after_circ_action called with action: renewal, ref: Koha::Checkout) # Looks like you failed 1 test of 1. not ok 2 - AddRenewal # Failed test 'AddRenewal' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 102. # Subtest: AddReturn 1..3 ok 1 - No hook called because no return happened not ok 2 - AddReturn calls the after_circ_action hook # Failed test 'AddReturn calls the after_circ_action hook' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 118. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: checkin, ref: Koha::Old::Checkout' # expected to find warning: (?^u:after_circ_action called with action: checkin, ref: Koha::Old::Checkout) ok 3 - AddReturn calls the after_circ_action hook # Looks like you failed 1 test of 3. not ok 3 - AddReturn # Failed test 'AddReturn' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 124. # Looks like you failed 3 tests of 3. not ok 4 - after_circ_action() hook tests Also, is there some quick code that I could add somewhere in order to manually confirm that the hook is working as intended? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- (In reply to Olivier Hubert from comment #2)
The fourth test fails on the current main branch:
# Subtest: after_circ_action() hook tests 1..3 # Subtest: AddIssue 1..2 not ok 1 - AddIssue calls the after_circ_action hook
# Failed test 'AddIssue calls the after_circ_action hook' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 80. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: checkout, ref: Koha::Checkout type: issue' # expected to find warning: (?^u:after_circ_action called with action: checkout, ref: Koha::Checkout type: issue) not ok 2 - AddIssue calls the after_circ_action hook (onsite_checkout case)
# Failed test 'AddIssue calls the after_circ_action hook (onsite_checkout case)' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 84. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: checkout, ref: Koha::Checkout type: onsite_checkout' # expected to find warning: (?^u:after_circ_action called with action: checkout, ref: Koha::Checkout type: onsite_checkout) # Looks like you failed 2 tests of 2. not ok 1 - AddIssue
# Failed test 'AddIssue' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 86. # Subtest: AddRenewal 1..1 not ok 1 - AddRenewal calls the after_circ_action hook
# Failed test 'AddRenewal calls the after_circ_action hook' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 100. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: renewal, ref: Koha::Checkout' # expected to find warning: (?^u:after_circ_action called with action: renewal, ref: Koha::Checkout) # Looks like you failed 1 test of 1. not ok 2 - AddRenewal
# Failed test 'AddRenewal' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 102. # Subtest: AddReturn 1..3 ok 1 - No hook called because no return happened not ok 2 - AddReturn calls the after_circ_action hook
# Failed test 'AddReturn calls the after_circ_action hook' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 118. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: D6ga8T7MA1bjQa7tEaRKLbwB' # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_circ_action called with action: checkin, ref: Koha::Old::Checkout' # expected to find warning: (?^u:after_circ_action called with action: checkin, ref: Koha::Old::Checkout) ok 3 - AddReturn calls the after_circ_action hook # Looks like you failed 1 test of 3. not ok 3 - AddReturn
# Failed test 'AddReturn' # at t/db_dependent/Koha/Plugins/Circulation_hooks.t line 124. # Looks like you failed 3 tests of 3. not ok 4 - after_circ_action() hook tests
Also, is there some quick code that I could add somewhere in order to manually confirm that the hook is working as intended?
Works for me, either could have been some regression in Koha (there is another exception thrown which causes the test to fail) that has now been fixed. We use it in our production environment and it works as intended. The hook tests could be more extensive I suppose, but since have limited time I will not write more extensive tests for this than exists for the other hooks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163097|0 |1 is obsolete| | --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189833&action=edit Bug 36303: Add after_circ_action hook action for checking in item that was not checked out To test: 1) Run tests in t/db_dependent/Koha/Plugins/Circulation_hooks.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from David Gustafsson <glasklas@gmail.com> --- Rebased against main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Patch complexity|--- |Small patch Comma delimited| |Gothenburg University list of Sponsors| |Library Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 201123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201123&action=edit Bug 36303: Add after_circ_action hook action for checking in item that was not checked out To test: 1) Run tests in t/db_dependent/Koha/Plugins/Circulation_hooks.t Sponsored-by: Gothenburg University Library Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36303 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Amended the patch for tidiness. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org