[Bug 8318] New: update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Priority: P5 - low Change sponsored?: --- Bug ID: 8318 Assignee: nengard@gmail.com Summary: update StatisticsFields description Severity: minor Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: ASSIGNED Version: master Component: Templates Depends on: 7955 Product: Koha StatisticsFields says "___ Define Fields (from the items table) used for statistics members (separate fields with |, for example:"location|itype|ccode")." Originally I thought this was related to the statistical member type - so I recommend the following language change for this preference: "Show the following fields from the items database table as columns on the statistics tab on the patron record: ___ (separate fields with |)" Patch to follow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 10511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10511&action=edit Bug 8318: Update StatisticsFields preference language This patch changes around the wording of the StatisticsFields preference to make it clearer where these values will show. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10511|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 10534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10534&action=edit [SIGNED-OFF] Bug 8318: Update StatisticsFields preference language This patch changes around the wording of the StatisticsFields preference to make it clearer where these values will show. Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Changes the description for the syspref StatisticsFields Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... the patch does not apply, probably because I fixed the yaml syntax recently. Could you rebase & resubmit, I don't want to do a mistake (directly passed QA status) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Paul, I just did a fetch from master and applied the patch just fine ... nengard@kohavm:~/kohaclone$ git bz apply 8318 Bug 8318 - update StatisticsFields description [SIGNED-OFF] Bug 8318: Update StatisticsFields preference language Apply? [yn] y Applying: Bug 8318: Update StatisticsFields preference language nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #5)
Paul,
I just did a fetch from master and applied the patch just fine ... ??? That's strange, I get the following conflict: 134 <<<<<<< HEAD 135 - Define Fields (from the items table) used for statistics members (separate fields with |, for example :"location|itype|ccode"). 136 - 137 - pref: EnableBorrowerFiles 138 choices: 139 yes: Do 140 no: "Don't" 141 - enable the ability to upload and attach arbitrary files to a borrower record. 142 ======= 143 - (separate fields with |) 144 >>>>>>> Bug 8318: Update StatisticsFields preference language
I've rewritten you patch, and pushed, this will remain a mistery -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org