[Bug 42867] New: Add debugging option for the holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Bug ID: 42867 Summary: Add debugging option for the holds queue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The holds queue can be complex, and libraries often have questions about how the items are chosen. We should provide a debugging option for the holds queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 200676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200676&action=edit Bug 42867: Add HoldsQueueDebug system preference This patch adds a new system preference HoldsQueueDebug When enabled this adds the item map to the action logs for the holds queue cronjob and to the messages of the background job for the real time holds queue. This additionally adds a match_type that indicates which section of the code has assigned the item to the hold To test: 1 - Apply the patches, updatedatabase, restart_all 2 - Enable the new HoldsQueueDebug system preference 3 - Enable the transport cost matrix 4 - Place some holds for and from various libraries 5 - Run the holds queue: perl misc/cronjobs/holds/build_holds_queue.pl 6 - Check the action logs and note the extra info stored 7 - Enable Real time holds queue preference 8 - Add another hold to a record 9 - Check the background job details Administration->Jobs->Details 10 - Note the new table displaying the item map 11 - Disable the pref and confirm running the cron or adding a hold does not add debug info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jvinke@austinseminary.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 202961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202961&action=edit Bug 42867: Add HoldsQueueDebug system preference This patch adds a new system preference HoldsQueueDebug When enabled this adds the item map to the action logs for the holds queue cronjob and to the messages of the background job for the real time holds queue. This additionally adds a match_type that indicates which section of the code has assigned the item to the hold To test: 1 - Apply the patches, updatedatabase, restart_all 2 - Enable the new HoldsQueueDebug system preference 3 - Enable the transport cost matrix 4 - Place some holds for and from various libraries 5 - Run the holds queue: perl misc/cronjobs/holds/build_holds_queue.pl 6 - Check the action logs and note the extra info stored 7 - Enable Real time holds queue preference 8 - Add another hold to a record 9 - Check the background job details Administration->Jobs->Details 10 - Note the new table displaying the item map 11 - Disable the pref and confirm running the cron or adding a hold does not add debug info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from John Vinke <jvinke@austinseminary.edu> --- Failed QA because while I was able to apply the patch, but now I get an error when I try to run the cron job. This does not happen if I attempt to run the same cron when the patch isn't applied. Undefined subroutine &main::cronlogaction called at misc/cronjobs/holds/build_holds_queue.pl line 92. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Did you do: dbic && updatedatabase && yarn build && restart_all After applying the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #5 from John Vinke <jvinke@austinseminary.edu> --- I did "Apply the patches, updatedatabase, restart_all" the first time, but tried again this time doing all of those commands Lisette mentioned in the order specified and had the same result. Is it possible that this function wasn't imported? I see other files that call this having the line below in the file, but the one mentioned in the error doesn't have it. (Or at least not for me. I'm very open to this being me having doing something wrong here.) use C4::Log qw( cronlogaction ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 204746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204746&action=edit Bug 42867: Add HoldsQueueDebug system preference This patch adds a new system preference HoldsQueueDebug When enabled this adds the item map to the action logs for the holds queue cronjob and to the messages of the background job for the real time holds queue. This additionally adds a match_type that indicates which section of the code has assigned the item to the hold To test: 1 - Apply the patches, updatedatabase, restart_all 2 - Enable the system preferences: HoldsQueueDebug UseTransportCostMatrix CronjobLog 3 - You will need to populate the Transport Cost Matrix as well: http://localhost:8081/cgi-bin/koha/admin/transport-cost-matrix.pl You can click 'Enable all' and 'Populate empty cells - 10' 4 - Place some holds for and from various libraries 5 - Run the holds queue: perl misc/cronjobs/holds/build_holds_queue.pl --force 6 - Check the action logs for cronjobs and note the extra info stored 7 - Enable RealTimeHoldsQueue preference 8 - Add another hold to a record 9 - Check the background job details Administration->Jobs->Details 10 - Note the new table displaying the item map 11 - Disable the pref and confirm running the cron or adding a hold does not add debug info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to John Vinke from comment #5)
Is it possible that this function wasn't imported? I see other files that call this having the line below in the file, but the one mentioned in the error doesn't have it. (Or at least not for me. I'm very open to this being me having doing something wrong here.)
use C4::Log qw( cronlogaction );
You are correct, amended the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #8 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 205091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205091&action=edit Bug 42867: Add HoldsQueueDebug system preference This patch adds a new system preference HoldsQueueDebug When enabled this adds the item map to the action logs for the holds queue cronjob and to the messages of the background job for the real time holds queue. This additionally adds a match_type that indicates which section of the code has assigned the item to the hold To test: 1 - Apply the patches, updatedatabase, restart_all 2 - Enable the system preferences: HoldsQueueDebug UseTransportCostMatrix CronjobLog 3 - You will need to populate the Transport Cost Matrix as well: http://localhost:8081/cgi-bin/koha/admin/transport-cost-matrix.pl You can click 'Enable all' and 'Populate empty cells - 10' 4 - Place some holds for and from various libraries 5 - Run the holds queue: perl misc/cronjobs/holds/build_holds_queue.pl --force 6 - Check the action logs for cronjobs and note the extra info stored 7 - Enable RealTimeHoldsQueue preference 8 - Add another hold to a record 9 - Check the background job details Administration->Jobs->Details 10 - Note the new table displaying the item map 11 - Disable the pref and confirm running the cron or adding a hold does not add debug info Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207830&action=edit Bug 42867: Add HoldsQueueDebug system preference This patch adds a new system preference HoldsQueueDebug When enabled this adds the item map to the action logs for the holds queue cronjob and to the messages of the background job for the real time holds queue. This additionally adds a match_type that indicates which section of the code has assigned the item to the hold To test: 1 - Apply the patches, updatedatabase, restart_all 2 - Enable the system preferences: HoldsQueueDebug UseTransportCostMatrix CronjobLog 3 - You will need to populate the Transport Cost Matrix as well: http://localhost:8081/cgi-bin/koha/admin/transport-cost-matrix.pl You can click 'Enable all' and 'Populate empty cells - 10' 4 - Place some holds for and from various libraries 5 - Run the holds queue: perl misc/cronjobs/holds/build_holds_queue.pl --force 6 - Check the action logs for cronjobs and note the extra info stored 7 - Enable RealTimeHoldsQueue preference 8 - Add another hold to a record 9 - Check the background job details Administration->Jobs->Details 10 - Note the new table displaying the item map 11 - Disable the pref and confirm running the cron or adding a hold does not add debug info Signed-off-by: John Vinke <jvinke@austinseminary.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42867 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org