[Bug 28906] New: Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Bug ID: 28906 Summary: Koha::Items->filter_by_visible_in_opac doesn't honour list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28883 Depends on| |26223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 [Bug 26223] The OPAC ISBD view does not display item information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124112&action=edit Bug 28906: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124113&action=edit Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context This patch makes the method honour list context. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => FAIL: Tests fail! It returns [Koha::Items]. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124114&action=edit Bug 28906: (26223 follow-up) Remove use of as_list This bug makes Koha::Items->filter_by_visible_in_opac honour list context, so this explicit call is not needed. To test: 1. Pick a biblio in the OPAC 2. Go to the ISBD view => SUCCESS: It renders correctly 3. Apply this patch and restart Plack 4. Refresh the ISBD view page => SUCCESS: It doesn't break! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124114|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124115&action=edit Bug 28906: (26223 follow-up) Remove use of as_list This bug makes Koha::Items->filter_by_visible_in_opac honour list context, so this explicit call is not needed. To test: 1. Pick a biblio in the OPAC 2. Go to the ISBD view => SUCCESS: It renders correctly 3. Apply this patch and restart Plack 4. Refresh the ISBD view page => SUCCESS: It doesn't break! 5. Check opac-reserve.pl doesn't break either 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124112|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 125035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125035&action=edit Bug 28906: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124113|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 125036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125036&action=edit Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context This patch makes the method honour list context. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => FAIL: Tests fail! It returns [Koha::Items]. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124115|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 125037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125037&action=edit Bug 28906: (26223 follow-up) Remove use of as_list This bug makes Koha::Items->filter_by_visible_in_opac honour list context, so this explicit call is not needed. To test: 1. Pick a biblio in the OPAC 2. Go to the ISBD view => SUCCESS: It renders correctly 3. Apply this patch and restart Plack 4. Refresh the ISBD view page => SUCCESS: It doesn't break! 5. Check opac-reserve.pl doesn't break either 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Bug 28906 depends on bug 26223, which changed state. Bug 26223 Summary: The OPAC ISBD view does not display item information https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125035|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125258&action=edit Bug 28906: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125036|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125259&action=edit Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context This patch makes the method honour list context. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => FAIL: Tests fail! It returns [Koha::Items]. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125037|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125260&action=edit Bug 28906: (26223 follow-up) Remove use of as_list This bug makes Koha::Items->filter_by_visible_in_opac honour list context, so this explicit call is not needed. To test: 1. Pick a biblio in the OPAC 2. Go to the ISBD view => SUCCESS: It renders correctly 3. Apply this patch and restart Plack 4. Refresh the ISBD view page => SUCCESS: It doesn't break! 5. Check opac-reserve.pl doesn't break either 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected, no regressions found, QA scripts happy and tests all passing. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Blocked by the discussion on bug 28883. IF we decide to remove wantarray it does not make sense to have this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29844 Resolution|--- |INVALID Status|BLOCKED |RESOLVED --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- We decided to actually drop support for wantarray altogether in Koha::Objects. See bug 29844. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org