[Bug 30389] New: Switch to Bootstrap tabs on the page for adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Bug ID: 30389 Summary: Switch to Bootstrap tabs on the page for adding orders from MARC file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30388 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the 'Add orders from MARC file' page with Bootstrap tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 [Bug 30388] Fix some errors in the template for ordering from a MARC file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132359&action=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132359|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132821&action=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Really nice Owen ! The alignment of the first tab is really better with the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am afraid this is not quite ready for QA yet with the 2 dependent bugs not yet signed off. Moving to BLOCKED, back to QA queue soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132821|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138133&action=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138133|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138235&action=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Bug 30389 depends on bug 30388, which changed state. Bug 30388 Summary: Fix some errors in the template for ordering from a MARC file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 22.05.x dependencies, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org