[Bug 21182] New: acqui/check_duplicate_barcode_ajax.pl is not longer in used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Bug ID: 21182 Summary: acqui/check_duplicate_barcode_ajax.pl is not longer in used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 6963, 7178 It has been added by commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. But its last call removed since: commit eefc774e274ce8167f1063be5f9204a0d5cf5650 Bug 7178: Acquisition item creation improvement Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 [Bug 6963] When creating a new order, the item isn't added if its barcode already exists in the items table. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178 [Bug 7178] Improve order item creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77583&action=edit Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl It has been added by commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. But its last call removed since: commit eefc774e274ce8167f1063be5f9204a0d5cf5650 Bug 7178: Acquisition item creation improvement Test plan: git grep check_duplicate_barcode should not return anything -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|acqui/check_duplicate_barco |acqui/check_duplicate_barco |de_ajax.pl is not longer in |de_ajax.pl is not longer in |used |use CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77583|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77629&action=edit Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl It has been added by commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. But its last call removed since: commit eefc774e274ce8167f1063be5f9204a0d5cf5650 Bug 7178: Acquisition item creation improvement Test plan: git grep check_duplicate_barcode should not return anything Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Verified I can't find any uses of this at all before the patch and the reasoning is clear from Jonathans comments and the git logs. Verified the patch works as expected. Going straight to Passed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to push to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org