[Bug 11608] New: don't need the word 'library' on funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Bug ID: 11608 Summary: don't need the word 'library' on funds Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/acqui-home.pl OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: nengard@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Most libraries have the word library in their name - and even if they don't showing 'library' next to the library's name is not really necessary on the list of acq funds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 24694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24694&action=edit Library 2 times -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 24695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24695&action=edit [Bug 11608] Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24700&action=edit Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24695|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24700|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24701&action=edit Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: remove a space -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24702&action=edit Bug 11608: Delete unused commented lines in template On the way, these lines are commented and can be deleted safely. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24701|0 |1 is obsolete| | Attachment #24702|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24727&action=edit [PASSED QA] Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: remove a space Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24728&action=edit [PASSED QA] Bug 11608: Delete unused commented lines in template On the way, these lines are commented and can be deleted safely. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Removes an HTML comment with unused code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org