https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16551 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 [Bug 16551] Display the name of lists to the search results at the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 128246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128246&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128247|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 128282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128282&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- This is all working fine but the private lists add this bit: <span class="privateshelf">Private</span> which creates a display like this: Lists that include this title: list1 Private | list2 To me, that looks a little confusing. Would something like this be better? Lists that include this title: list1(Private) | list2 Also, lists are pipe separated on the detail page and comma separated on the results page. Should this be consistent? Maybe even make them CSS pseudo elements but perhaps we need Bug 27613 to get in first. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- *** Bug 19342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 pierre.fagot@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128282|0 |1 is obsolete| | --- Comment #9 from pierre.fagot@biblibre.com --- Created attachment 130233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130233&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pierre Fagot <pierre.fagot@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 pierre.fagot@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.fagot@biblibre.com Status|Needs Signoff |Signed Off --- Comment #11 from pierre.fagot@biblibre.com --- I have executed the test plan everything is working. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- catalogue/results.tt has a link to opac-shelves.pl I am not convinced by this enhancement. It is going to add extra processing for each record displayed in the search result. And this page is already too slow. Maybe it could be driven by a syspref, off by default? -- You are receiving this mail because: You are watching all bug changes.