[Bug 32650] New: Koha/Holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Bug ID: 32650 Summary: Koha/Holds.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 25551 15:36:13 koha_1 | # Failed test 'Items 1, 2, and 5 are available for filling the holds' 15:36:13 koha_1 | # at t/db_dependent/Koha/Holds.t line 532. 15:36:13 koha_1 | # Structures begin differing at: 15:36:13 koha_1 | # $got->[0] = '1000' 15:36:13 koha_1 | # $expected->[0] = '996' 15:36:13 koha_1 | # Looks like you failed 1 test of 6. 15:36:13 koha_1 | 15:36:13 koha_1 | # Failed test 'get_items_that_can_fill' 15:36:13 koha_1 | # at t/db_dependent/Koha/Holds.t line 540. Koha_Master_D10/1002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Koha_22.05_U20/130 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Koha_22.05_U20/130
And it was the exact same numbers! 22:25:51 koha_1 | # Failed test 'Items 1, 2, and 5 are available for filling the holds' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 531. 22:25:51 koha_1 | # Structures begin differing at: 22:25:51 koha_1 | # $got->[0] = '1000' 22:25:51 koha_1 | # $expected->[0] = '996' 22:25:51 koha_1 | # Looks like you failed 1 test of 6. 22:25:51 koha_1 | 22:25:51 koha_1 | # Failed test 'get_items_that_can_fill' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 539. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- ha... sort... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145394&action=edit Bug 32650: Prevent Koha/Holds.t to fail randomly 22:25:51 koha_1 | # Failed test 'Items 1, 2, and 5 are available for filling the holds' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 531. 22:25:51 koha_1 | # Structures begin differing at: 22:25:51 koha_1 | # $got->[0] = '1000' 22:25:51 koha_1 | # $expected->[0] = '996' 22:25:51 koha_1 | # Looks like you failed 1 test of 6. 22:25:51 koha_1 | 22:25:51 koha_1 | # Failed test 'get_items_that_can_fill' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 539. We need to use a numeric sort, or 1000 is before 996... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145394|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145397&action=edit Bug 32650: Prevent Koha/Holds.t to fail randomly 22:25:51 koha_1 | # Failed test 'Items 1, 2, and 5 are available for filling the holds' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 531. 22:25:51 koha_1 | # Structures begin differing at: 22:25:51 koha_1 | # $got->[0] = '1000' 22:25:51 koha_1 | # $expected->[0] = '996' 22:25:51 koha_1 | # Looks like you failed 1 test of 6. 22:25:51 koha_1 | 22:25:51 koha_1 | # Failed test 'get_items_that_can_fill' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 539. We need to use a numeric sort, or 1000 is before 996... Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I'm not able to reproduce the failure but I can confirm that the test passes successfully with the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145397|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145402&action=edit Bug 32650: Prevent Koha/Holds.t to fail randomly 22:25:51 koha_1 | # Failed test 'Items 1, 2, and 5 are available for filling the holds' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 531. 22:25:51 koha_1 | # Structures begin differing at: 22:25:51 koha_1 | # $got->[0] = '1000' 22:25:51 koha_1 | # $expected->[0] = '996' 22:25:51 koha_1 | # Looks like you failed 1 test of 6. 22:25:51 koha_1 | 22:25:51 koha_1 | # Failed test 'get_items_that_can_fill' 22:25:51 koha_1 | # at t/db_dependent/Koha/Holds.t line 539. We need to use a numeric sort, or 1000 is before 996... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Keep up the good work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32650 --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org